`Appearance.setColorScheme` notifies no `change` listener, so `useColorScheme()` readers show the old scheme until the platform reports it
維護者通常 2 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 66/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- android, javascript, react-native
研究方向
Read Appearance.js and useColorScheme.js, especially the setColorScheme and addChangeListener behavior described in the issue. Use the linked reproducer to observe whether calling Appearance.setColorScheme updates hook subscribers in the same commit. Done when both readers show the new scheme together and the listener behavior matches its documented contract.
由索引模型根據 Issue 內容生成。
描述
Description
Appearance.setColorScheme(scheme) sets the value Appearance.getColorScheme() returns at once and emits no change. useColorScheme() subscribes through addChangeListener, so a component that reads it keeps the old scheme until the native module reports appearanceChanged, while a component that re-renders for another reason in the same press already reads the new one, and one commit shows both schemes. addChangeListener's doc says its listener hears "a call to setColorScheme()" (Appearance.js).
Steps to reproduce
- Clone https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change and connect an Android device.
- Run
bash repro.sh, which buildsReproducerApp's release APK, installs and opens it, and taps the grey area once. By hand:yarn installandyarn androidinReproducerApp, then press the grey area once. - The press calls
Appearance.setColorScheme(next)and bumps a counter in the component that rendersAppearance.getColorScheme(); its sibling rendersuseColorScheme(). After each of its commits, each component logs what the screen shows, and achangelistener logs when it runs.
Expected: the commit the press makes shows the new scheme in both components.
Actual: that commit shows useColorScheme() dark beside Appearance.getColorScheme() light, and the useColorScheme() reader catches up only after the change listener runs.
React Native Version
0.88.1
Appearance.js and useColorScheme.js on main at b9a83f3a are the same files as in 0.88.1.
Affected Platforms
Runtime - Android
Output of npx @react-native-community/cli info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Memory: 128.21 GB / 255.67 GB
Binaries:
Node:
version: 26.12.1
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 1.22.22
path: C:\Users\…\AppData\Roaming\npm\yarn.CMD
npm:
version: 12.2.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
Versions:
- 10.0.19041.0
- 10.0.26100.0
IDEs:
Android Studio: AI-262.9437.185.2621.16467767
Visual Studio: Not Found
Languages:
Java:
version: 17.0.20.1
path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 20.2.0
wanted: 20.2.0
react:
installed: 19.3.0
wanted: 19.3.0
react-native:
installed: 0.88.1
wanted: 0.88.1
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Stacktrace or Logs
react-native 0.88.1, release build, SM-S911B, Android 14
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() dark (agree)
ready
press 1: Appearance.setColorScheme('light') and a state update
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() light (DISAGREE)
change listener: light, 2 ms after the press
the useColorScheme() reader committed: the screen shows useColorScheme() light and Appearance.getColorScheme() light (agree)
RESULT: defect shows: after Appearance.setColorScheme a commit shows useColorScheme() and Appearance.getColorScheme() disagreeing, until the change listener runs
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change
- 主要語言
- C++
- 星號
- 127k
- 分支
- 25.5k
- 平均合併
- 3 天 22 小時
- 30 天內合併 PR
- 235
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
react/react-native 的其他 Issue
-
Needs: Author Feedback Needs: Repro
難度 2/5 1-3 小時 新手友好度 82/100
react/react-native#60059 · 1 則留言 ·
維護者通常 2 天內回覆
-
Needs: Triage :mag:
難度 2/5 1-3 小時 新手友好度 70/100
react/react-native#60000 ·
維護者通常 2 天內回覆
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deleted可能已有人在做 @lazerg 於 4 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
react/react-native#59939 ·
維護者通常 2 天內回覆
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primary可能已有人在做 @alleneubank 於 6 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 68/100
react/react-native#59919 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 70/100
react/react-native#59722 ·
維護者通常 2 天內回覆
查看 react/react-native 的全部 Issue
相似的 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
petercorke/robotics-toolbox-python#943 · 1 則留言 ·
維護者通常 1 天內回覆
-
area:build bug
難度 1/5 1 小時以內 新手友好度 90/100
NatronGitHub/openfx-arena#71 ·
維護者通常 1 天內回覆
-
upstream-blocked
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
ROCm/FastFlowLM#1057 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
NatronGitHub/openfx-gmic#45 ·
維護者通常 1 天內回覆