Integer control callbacks lose fractional vehicle limits and stop motion

Aberta
  • Algo errado?
#936 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@Elon-Jiang já está trabalhando nisso.

Desde 10/11/2026.

  • #937 de @Elon-Jiang — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
20/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Estagnada
Stack de tecnologia
python
Domínio
backend

Direção de pesquisa

Read the three u_limited methods in Vehicle.py and trace how integer control inputs determine the result dtype. Reproduce the reported difference between integer and floating callback commands with the public step example, then add regression coverage for the limit methods and callback path. The issue reports an open linked pull request (#937), so the work is already under way.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

RTB version

1.5.0, current main 879fb363580840e19ee70b6b175e8cd3543e2b38 (normal editable install with compiled extensions).

Python version and OS

Python 3.12.13, macOS arm64.

Expected behaviour

An integer-valued control callback should produce the same limited motion as the equivalent floating-valued callback. The documented ArrayLike inputs include integer lists/arrays.

Actual behaviour

u_limited in Bicycle, Unicycle and DiffSteer allocates an integer result for integer inputs, then truncates fractional speed, acceleration or steering limits on assignment. For example, a desired speed of 1 limited to 0.5 becomes 0. This also reaches the public simulator through a control callback:

import roboticstoolbox as rtb

for command in ([1, 0], [1.0, 0.0]):
    vehicle = rtb.Bicycle(speed_max=0.5, dt=0.1)
    vehicle.step(lambda vehicle, t, x: command, animate=False)
    print(command, vehicle.x)

Current main prints [0., 0., 0.] for the integer callback and [0.05, 0., 0.] for the floating callback. Unicycle and DiffSteer reproduce the same lost motion. Direct constant step([1, 0]) is a passing control, since eval_control already converts that route to floating point. No rendering or robot hardware is involved.

I checked all 24 open PR file lists, full history for Vehicle.py, and complete searches for u_limited, limits_va, integer velocity and acceleration. #929 changes the sign of reverse odometry; it does not change control limiting.

I plan a focused floating-output correction in these three limit methods and regression coverage through both u_limited and the public step callback path. Prepared with assistance from OpenAI Codex (GPT-6).

Linguagem predominante
C++
Estrelas
3.6k
Forks
650
Merge médio
14h 6min
PRs com merge (30d)
139

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de petercorke/robotics-toolbox-python

Todas as issues de petercorke/robotics-toolbox-python

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.