Integer control callbacks lose fractional vehicle limits and stop motion

Offen
  • Stimmt etwas nicht?
#936 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@Elon-Jiang arbeitet bereits daran.

Seit 10.11.2026.

  • #937 von @Elon-Jiang — offen

Bewertung

Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Anfängerfreundlichkeit
20/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
python
Bereich
backend

Rechercherichtung

Read the three u_limited methods in Vehicle.py and trace how integer control inputs determine the result dtype. Reproduce the reported difference between integer and floating callback commands with the public step example, then add regression coverage for the limit methods and callback path. The issue reports an open linked pull request (#937), so the work is already under way.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

RTB version

1.5.0, current main 879fb363580840e19ee70b6b175e8cd3543e2b38 (normal editable install with compiled extensions).

Python version and OS

Python 3.12.13, macOS arm64.

Expected behaviour

An integer-valued control callback should produce the same limited motion as the equivalent floating-valued callback. The documented ArrayLike inputs include integer lists/arrays.

Actual behaviour

u_limited in Bicycle, Unicycle and DiffSteer allocates an integer result for integer inputs, then truncates fractional speed, acceleration or steering limits on assignment. For example, a desired speed of 1 limited to 0.5 becomes 0. This also reaches the public simulator through a control callback:

import roboticstoolbox as rtb

for command in ([1, 0], [1.0, 0.0]):
    vehicle = rtb.Bicycle(speed_max=0.5, dt=0.1)
    vehicle.step(lambda vehicle, t, x: command, animate=False)
    print(command, vehicle.x)

Current main prints [0., 0., 0.] for the integer callback and [0.05, 0., 0.] for the floating callback. Unicycle and DiffSteer reproduce the same lost motion. Direct constant step([1, 0]) is a passing control, since eval_control already converts that route to floating point. No rendering or robot hardware is involved.

I checked all 24 open PR file lists, full history for Vehicle.py, and complete searches for u_limited, limits_va, integer velocity and acceleration. #929 changes the sign of reverse odometry; it does not change control limiting.

I plan a focused floating-output correction in these three limit methods and regression coverage through both u_limited and the public step callback path. Prepared with assistance from OpenAI Codex (GPT-6).

Vorherrschende Sprache
C++
Sterne
3.6k
Forks
650
Ø Merge
14 Std. 6 Min.
Gemergte PRs (30 T.)
139

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus petercorke/robotics-toolbox-python

Alle Issues in petercorke/robotics-toolbox-python

Ähnliche Issues

Weitere Issues zu C++

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.