Give find and resolve coherent configuration snapshots without lock-held discovery
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Facilidade para iniciantes
- 25/100
- Tipo de issue
- Refatoração
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- rust
- Domínio
- api, backend, documentation, performance, testing-qa
Direção de pesquisa
Start with the configure, resolve, and find sections in crates/pet/src/jsonrpc.rs and the refresh-state contract in docs/LOCATOR_STATE.md; review #531 metrics and the #533 concurrency workload first. Define and test coherent old-or-new snapshots without holding configuration locks during filesystem or subprocess I/O. Done means the listed barrier, ordering, failure, refresh, cache, latency, and documentation criteria pass without regressing #385 or #461.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Tracking plan: #528
Priority: P2. Evidence: source-confirmed ownership inconsistency; add deterministic race tests before claiming a reproduced user failure.
Problem
Refresh uses a transient locator graph and a configuration-generation snapshot. Find/resolve still use the long-lived shared graph while configure mutates its locators one by one before publishing the new generation. Those operations can therefore observe partially applied configuration even though refresh has a coherent boundary.
Additionally, find passes a chained configuration read/clone expression directly into discovery; the temporary read guard can live through that call, retaining the configuration lock during filesystem work.
Sources: configure prepare/mutate/publish, resolve, find, refresh-state contract.
Scope
- First make find's configuration snapshot an explicit local value and release its guard before discovery.
- Define one coherent request-snapshot boundary for configure/refresh/find/resolve. Prefer constructing the replacement configuration/locator graph off-lock and atomically publishing it, rather than extending broad locks across I/O.
- Separate deliberately shared performance caches from configured input and correctness-critical discovery state. Preserve current generation-gated notifications, locator ordering, scoped refresh-state sync, and coalescing semantics.
- Replace unnecessary mutable-graph rollback complexity only where the new ownership model demonstrably removes the failure mode; do not bundle unrelated rewrites.
Acceptance criteria
- Barrier/channel-driven tests prove find and resolve see either the old or new configuration, never a mix across locators.
- Slow discovery/configuration fixtures do not hold a global configuration lock over filesystem or subprocess I/O.
- Concurrent configures publish in a defined order; failures leave the previous usable snapshot intact.
- Full/workspace/kind-filtered refresh sync, stale notification suppression, joined refresh replies, and manager fidelity retain existing behavior.
- In-flight cache invalidation/clear and configuration changes have explicit tested semantics.
- No regression in client-observed latency or long-lived cache behavior, and locator-state documentation includes the actual lifetime of every locator's mutable state.
Dependencies and prior work
Use #531 metrics and the #533 long-lived/concurrency workload before broad ownership changes. This establishes the ownership foundation for #539 and #540; the complete order is in #528. #385 fixed configure versus refresh isolation; #461 removed locator I/O from the configuration write lock. This issue extends consistency to find/resolve and must not regress either fix.
- Linguagem predominante
- Rust
- Estrelas
- 207
- Forks
- 45
- Merge médio
- 3d 6h
- PRs com merge (30d)
- 12
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de microsoft/python-environment-tools
-
enhancement
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
-
debt
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 25/100
microsoft/python-environment-tools#538 · 1 comentário ·
-
enhancement
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
-
debt
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
-
enhancement
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 35/100
microsoft/python-environment-tools#533 · 2 comentários ·
Todas as issues de microsoft/python-environment-tools
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 88/100
-
bug core
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 86/100
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Abertafuzz
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
ClickHouse/ClickHouse#122114 ·
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 92/100
linebender/vello_svg#90 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 74/100