[Plugin] Preserve handler errors in invocation-end hooks when returning PENDING

Aberta
  • Algo errado?
#772 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
62/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
aws, python
Domínio
backend

Direção de pesquisa

Start with the revoked-token branches in execution.py around lines 449-463, which replace the handler error with an error-free PENDING output, then read plugin.py around lines 845-851, where the invocation output is rebuilt from the service-response dictionary. The JavaScript answerPending in with-durable-execution.ts shows the separation to copy: forward the error to plugins while returning bare PENDING. Done means the invocation-end hook gets PENDING with the original error, the service response stays exactly {"Status": "PENDING"}, and unit tests check both.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

parity
Expected behavior

When a handler raises an error and checkpoint-token withdrawal requires a PENDING response, the invocation-end hook should retain the original error details in InvocationEndInfo.error. Its status should remain PENDING.

The service response must remain exactly {"Status": "PENDING"}. It must contain neither Error nor Result. Ordinary suspension without a handler error should continue to report error=None.

Actual behavior

The revoked-token branches replace handler errors with an error-free pending output in execution.py:449–463.

The plugin wrapper reconstructs its invocation output from that service-response dictionary in plugin.py:845–851. So the invocation-end hook receives PENDING without the handler error.

JavaScript separates these outputs. Its answerPending implementation, with-durable-execution.ts:184–198, forwards executionError to plugins but returns bare PENDING to the service.

Reproduction scenario
  1. Register a plugin that records the invocation-end status and error.
  2. Invoke a handler that raises ValueError("handler failed").
  3. Arrange for checkpoint-token withdrawal before the wrapper handles that exception.
  4. Inspect the hook payload and returned dictionary.

The dictionary is bare PENDING, as required. The hook error is None, so the handler failure details are lost.

This scenario follows from source inspection at Python revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Preserve the original handler error details in exactly one PENDING invocation-end notification.
  • Keep the service response exactly {"Status": "PENDING"}.
  • Keep suspension without a handler error free of fabricated errors.
  • Add unit coverage that checks the hook payload and service response together.
  • Add an end-to-end regression for the handler-to-plugin path.
  • Preserve existing success, failure, and retry behavior.
Context

Follow-up to PR #757’s plugin-error parity discussion.

Linguagem predominante
Python
Estrelas
58
Forks
32
Merge médio
1d 6h
PRs com merge (30d)
80

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de aws/aws-durable-execution-sdk-python

Todas as issues de aws/aws-durable-execution-sdk-python

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.