[Plugin] Preserve handler errors in invocation-end hooks when returning PENDING

オープン
  • 何か問題がありますか？
#772 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
62/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
aws, python
領域
backend

調査の方向性

Start with the revoked-token branches in execution.py around lines 449-463, which replace the handler error with an error-free PENDING output, then read plugin.py around lines 845-851, where the invocation output is rebuilt from the service-response dictionary. The JavaScript answerPending in with-durable-execution.ts shows the separation to copy: forward the error to plugins while returning bare PENDING. Done means the invocation-end hook gets PENDING with the original error, the service response stays exactly {"Status": "PENDING"}, and unit tests check both.

索引モデルが issue の本文から書いたものです。

説明

parity
Expected behavior

When a handler raises an error and checkpoint-token withdrawal requires a PENDING response, the invocation-end hook should retain the original error details in InvocationEndInfo.error. Its status should remain PENDING.

The service response must remain exactly {"Status": "PENDING"}. It must contain neither Error nor Result. Ordinary suspension without a handler error should continue to report error=None.

Actual behavior

The revoked-token branches replace handler errors with an error-free pending output in execution.py:449–463.

The plugin wrapper reconstructs its invocation output from that service-response dictionary in plugin.py:845–851. So the invocation-end hook receives PENDING without the handler error.

JavaScript separates these outputs. Its answerPending implementation, with-durable-execution.ts:184–198, forwards executionError to plugins but returns bare PENDING to the service.

Reproduction scenario
  1. Register a plugin that records the invocation-end status and error.
  2. Invoke a handler that raises ValueError("handler failed").
  3. Arrange for checkpoint-token withdrawal before the wrapper handles that exception.
  4. Inspect the hook payload and returned dictionary.

The dictionary is bare PENDING, as required. The hook error is None, so the handler failure details are lost.

This scenario follows from source inspection at Python revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Preserve the original handler error details in exactly one PENDING invocation-end notification.
  • Keep the service response exactly {"Status": "PENDING"}.
  • Keep suspension without a handler error free of fabricated errors.
  • Add unit coverage that checks the hook payload and service response together.
  • Add an end-to-end regression for the handler-to-plugin path.
  • Preserve existing success, failure, and retry behavior.
Context

Follow-up to PR #757’s plugin-error parity discussion.

主要言語
Python
スター
58
フォーク
32
平均マージ
1日 6時間
マージ済み PR（30日）
80

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

aws/aws-durable-execution-sdk-python のほかの issue

aws/aws-durable-execution-sdk-python の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。