[Plugin] Preserve handler errors in invocation-end hooks when returning PENDING

未关闭
  • 哪里不对？
#772 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
62/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
aws, python
领域
backend

调研方向

Start with the revoked-token branches in execution.py around lines 449-463, which replace the handler error with an error-free PENDING output, then read plugin.py around lines 845-851, where the invocation output is rebuilt from the service-response dictionary. The JavaScript answerPending in with-durable-execution.ts shows the separation to copy: forward the error to plugins while returning bare PENDING. Done means the invocation-end hook gets PENDING with the original error, the service response stays exactly {"Status": "PENDING"}, and unit tests check both.

由索引模型根据 Issue 内容生成。

描述

parity
Expected behavior

When a handler raises an error and checkpoint-token withdrawal requires a PENDING response, the invocation-end hook should retain the original error details in InvocationEndInfo.error. Its status should remain PENDING.

The service response must remain exactly {"Status": "PENDING"}. It must contain neither Error nor Result. Ordinary suspension without a handler error should continue to report error=None.

Actual behavior

The revoked-token branches replace handler errors with an error-free pending output in execution.py:449–463.

The plugin wrapper reconstructs its invocation output from that service-response dictionary in plugin.py:845–851. So the invocation-end hook receives PENDING without the handler error.

JavaScript separates these outputs. Its answerPending implementation, with-durable-execution.ts:184–198, forwards executionError to plugins but returns bare PENDING to the service.

Reproduction scenario
  1. Register a plugin that records the invocation-end status and error.
  2. Invoke a handler that raises ValueError("handler failed").
  3. Arrange for checkpoint-token withdrawal before the wrapper handles that exception.
  4. Inspect the hook payload and returned dictionary.

The dictionary is bare PENDING, as required. The hook error is None, so the handler failure details are lost.

This scenario follows from source inspection at Python revision 52b63b5f; it has not been executed for this report.

Acceptance criteria
  • Preserve the original handler error details in exactly one PENDING invocation-end notification.
  • Keep the service response exactly {"Status": "PENDING"}.
  • Keep suspension without a handler error free of fabricated errors.
  • Add unit coverage that checks the hook payload and service response together.
  • Add an end-to-end regression for the handler-to-plugin path.
  • Preserve existing success, failure, and retry behavior.
Context

Follow-up to PR #757’s plugin-error parity discussion.

主要语言
Python
星标
58
派生
32
平均合并
1 天 6 小时
30 天内合并 PR
80

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

aws/aws-durable-execution-sdk-python 的其他 Issue

查看 aws/aws-durable-execution-sdk-python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。