psql tab completion broken for storage servers, tags, profiles and resource groups (pre-PG15 query format)

Aberta Para iniciantes
#2,316 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

@allenvox já está trabalhando nisso.

Desde 14/11/2026.

  • #2321 de @allenvox — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
72/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
c, postgresql
Domínio
cli, databases

Direção de pesquisa

As quatro macros Query_for_list_of_tags, Query_for_list_of_resgroups, Query_for_list_of_storage_servers e Query_for_list_of_profiles estão em src/bin/psql/tab-complete.c. Compare-as com Query_for_list_of_servers, que já usa a forma do PG16 com um único LIKE '%s'. Converta as quatro para essa forma, recompile o psql e verifique se o TAB após ALTER TAG t_ ou ALTER STORAGE SERVER s_ completa os nomes sem nenhum ERROR do coordinator. As regras relacionadas de COMMENT e DROP STORAGE SERVER são separadas e podem ser tratadas aqui ou em #2312.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Apache Cloudberry version

main

What happened

psql tab completion of object names does not work for four Cloudberry-specific object types: storage servers, tags, profiles and resource groups. Pressing TAB after ALTER STORAGE SERVER , ALTER TAG , DROP TAG , ALTER PROFILE , ALTER RESOURCE GROUP , etc. offers nothing, even when matching objects exist. Each attempt also logs a server-side ERROR on the coordinator.

Root cause. These four query macros in src/bin/psql/tab-complete.c still use the pre-PG15 template form:

Query_for_list_of_tags        ... WHERE substring(pg_catalog.quote_ident(tagname),1,%d)='%s'
Query_for_list_of_resgroups   ... WHERE substring(pg_catalog.quote_ident(rsgname),1,%d)='%s'
Query_for_list_of_storage_servers ... WHERE substring(pg_catalog.quote_ident(srvname),1,%d)='%s'
Query_for_list_of_profiles    ... WHERE substring(pg_catalog.quote_ident(profilename),1,%d)='%s'

Upstream commit 02b8048ba5d ("psql: improve tab-complete's handling of variant SQL names", PG15) changed the template contract. _complete_from_query() now does

appendPQExpBuffer(&query_buffer, simple_query, e_object_like, e_ref_object, e_ref_schema);

and expects a single LIKE '%s'. Upstream's own macros were converted when the PG16 code was merged, but these Cloudberry-specific ones were not. As a result, %d receives a char * (undefined behavior) and %s receives the NULL e_ref_object. The generated query looks like this:

ERROR:  negative substring length not allowed
STATEMENT:  SELECT pg_catalog.quote_ident(srvname) FROM pg_catalog.gp_storage_server
            WHERE substring(pg_catalog.quote_ident(srvname),1,-1478678816)='(null)'

When the garbage length happens to be positive, the query runs but matches nothing.

What you think should happen instead

Object names should complete. Convert the four macros to the PG16 form, as Query_for_list_of_servers already does:

#define Query_for_list_of_storage_servers \
" SELECT srvname "\
"   FROM pg_catalog.gp_storage_server "\
"  WHERE srvname LIKE '%s'"

The other three need the same change. The storage-server conversion has been verified: with psql rebuilt and driven through a pty, ALTER STORAGE SERVER <TAB> lists the servers, and the coordinator ERROR disappears.

How to reproduce
CREATE TAG t_demo;
CREATE PROFILE p_demo;
CREATE STORAGE SERVER s_demo OPTIONS (endpoint 'x');

In interactive psql, press TAB after each of the following. None of them completes:

  • ALTER TAG t_
  • ALTER PROFILE p_
  • ALTER STORAGE SERVER s_
  • ALTER RESOURCE GROUP admin_

The coordinator log gets one bad query per completion attempt, against gp_storage_server, pg_tag, pg_profile and pg_resgroup, all of the substring(...,1,<garbage>)='(null)' form.

Related completion bugs for storage servers (same area)

The single-word {"SERVER", Query_for_list_of_servers} entry in words_after_create, and the generic COMMENT ON X Y → IS rule, win over the multi-word "STORAGE SERVER". This gives:

  • DROP STORAGE SERVER <TAB> and CREATE STORAGE USER MAPPING FOR u STORAGE SERVER <TAB> complete foreign servers (for example gp_exttable_server).
  • COMMENT ON STORAGE SERVER <TAB> completes IS instead of a server name.
  • ALTER STORAGE SERVER s <TAB> offers RENAME TO, but the grammar has no such form.

The following additions were verified to fix the first three cases (the user-mapping case still needs its own rule):

else if (Matches("COMMENT", "ON", "STORAGE", "SERVER"))
    COMPLETE_WITH_QUERY(Query_for_list_of_storage_servers);
...
else if (Matches("DROP", "STORAGE", "SERVER") ||
         Matches("DROP", "STORAGE", "SERVER", "IF", "EXISTS"))
    COMPLETE_WITH_QUERY(Query_for_list_of_storage_servers);
Operating System

Linux (platform independent)

Anything else

Found while reviewing #2312. That PR touches the ALTER STORAGE SERVER <name> completion line but not the issues above. The storage-server part can be fixed there or here.

Linguagem predominante
C
Estrelas
1.4k
Forks
273
Merge médio
4d 6h
PRs com merge (30d)
105

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de apache/cloudberry

Todas as issues de apache/cloudberry

Issues semelhantes

Mais issues de C

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.