Vacuous CLI tests and untested --files, --changed-since, targetVersion edges

Aberta
#113 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
godot, typescript
Domínio
cli, testing-qa

Direção de pesquisa

Start with the listed cases in test/cli.test.ts, test/entry.test.ts, and test/removed-api.test.ts, then read the related CLI and version inference code in src/project/godot-version.ts. Run npm run build && npm test and check how the tests handle relative paths, Git errors, skipped built CLI tests, and version parsing. Done when the listed edge cases are covered and the tests run or skip with clear reasons.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

severity: low testing

Summary

Several CLI tests claim more than they check or can pass without running anything, and --files, --changed-since and targetVersion inference have untested edges.

Where

  • test/cli.test.ts:210-217: the "--files lints only the named files (relative or absolute ...)" test passes only absolute paths.
  • test/cli.test.ts:238-242: the --changed-since test returns, and so passes, if git init throws. Its commits also lack -c commit.gpgsign=false, so a developer with global commit signing enabled gets a confusing failure.
  • test/entry.test.ts:50,57,64,73: the built-CLI exit-code tests call ctx.skip() when dist/cli.js is missing. Running npm test without a build silently skips the only real-process exit-code tests. CI builds first, so CI is fine.
  • src/project/godot-version.ts:6-40 and test/removed-api.test.ts:80-118.

Test cases and fixes

  • Relative --files with the cwd at the root, and with the cwd elsewhere (vi.spyOn(process, "cwd")).
  • --changed-since with the root at repo/game: only files under game/ are returned, root-relative, including untracked files.
  • --files x.gd --changed-since HEAD: the union, without duplicates.
  • A file deleted since the ref: not reported, and no crash.
  • A renamed file reports the new path.
  • A root that is not a git work tree: exit 2 with "git diff failed".
  • --changed-since=-x: rejected with exit 2.
  • Replace the bare return with ctx.skip("git unavailable"), and pass -c commit.gpgsign=false.
  • Fail loudly when CI is set and dist/ is missing, or build in a vitest globalSetup.
  • config/features=PackedStringArray("4.10"): ordering is numeric. "4.3", "4.5" gives "4.5".
  • "5.0": pin the behaviour. Today it maps to "4.5" and applies the 4.x DB to Godot 5; it should probably be null or warn.
  • An unparseable project.godot gives godotVersion: null and does not throw.

Getting started

  • Relevant files: test/cli.test.ts, test/entry.test.ts, test/removed-api.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|test/cli.test.ts|--files/--changed-since

Linguagem predominante
TypeScript
Estrelas
0
Forks
6
Merge médio
1d 21h
PRs com merge (30d)
8

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de TMHSDigital/godot-correctness-mcp

Todas as issues de TMHSDigital/godot-correctness-mcp

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.