Vacuous CLI tests and untested --files, --changed-since, targetVersion edges

Ouverte
#113 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
godot, typescript
Domaine
cli, testing-qa

Piste de recherche

Start with the listed cases in test/cli.test.ts, test/entry.test.ts, and test/removed-api.test.ts, then read the related CLI and version inference code in src/project/godot-version.ts. Run npm run build && npm test and check how the tests handle relative paths, Git errors, skipped built CLI tests, and version parsing. Done when the listed edge cases are covered and the tests run or skip with clear reasons.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

severity: low testing

Summary

Several CLI tests claim more than they check or can pass without running anything, and --files, --changed-since and targetVersion inference have untested edges.

Where

  • test/cli.test.ts:210-217: the "--files lints only the named files (relative or absolute ...)" test passes only absolute paths.
  • test/cli.test.ts:238-242: the --changed-since test returns, and so passes, if git init throws. Its commits also lack -c commit.gpgsign=false, so a developer with global commit signing enabled gets a confusing failure.
  • test/entry.test.ts:50,57,64,73: the built-CLI exit-code tests call ctx.skip() when dist/cli.js is missing. Running npm test without a build silently skips the only real-process exit-code tests. CI builds first, so CI is fine.
  • src/project/godot-version.ts:6-40 and test/removed-api.test.ts:80-118.

Test cases and fixes

  • Relative --files with the cwd at the root, and with the cwd elsewhere (vi.spyOn(process, "cwd")).
  • --changed-since with the root at repo/game: only files under game/ are returned, root-relative, including untracked files.
  • --files x.gd --changed-since HEAD: the union, without duplicates.
  • A file deleted since the ref: not reported, and no crash.
  • A renamed file reports the new path.
  • A root that is not a git work tree: exit 2 with "git diff failed".
  • --changed-since=-x: rejected with exit 2.
  • Replace the bare return with ctx.skip("git unavailable"), and pass -c commit.gpgsign=false.
  • Fail loudly when CI is set and dist/ is missing, or build in a vitest globalSetup.
  • config/features=PackedStringArray("4.10"): ordering is numeric. "4.3", "4.5" gives "4.5".
  • "5.0": pin the behaviour. Today it maps to "4.5" and applies the 4.x DB to Godot 5; it should probably be null or warn.
  • An unparseable project.godot gives godotVersion: null and does not throw.

Getting started

  • Relevant files: test/cli.test.ts, test/entry.test.ts, test/removed-api.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|test/cli.test.ts|--files/--changed-since

Langage dominant
TypeScript
Étoiles
0
Forks
6
Merge moyen
1 j 21 h
PR mergées (30 j)
8

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/godot-correctness-mcp

Toutes les issues de TMHSDigital/godot-correctness-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.