Vacuous CLI tests and untested --files, --changed-since, targetVersion edges

オープン
#113 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
godot, typescript
領域
cli, testing-qa

調査の方向性

Start with the listed cases in test/cli.test.ts, test/entry.test.ts, and test/removed-api.test.ts, then read the related CLI and version inference code in src/project/godot-version.ts. Run npm run build && npm test and check how the tests handle relative paths, Git errors, skipped built CLI tests, and version parsing. Done when the listed edge cases are covered and the tests run or skip with clear reasons.

索引モデルが issue の本文から書いたものです。

説明

severity: low testing

Summary

Several CLI tests claim more than they check or can pass without running anything, and --files, --changed-since and targetVersion inference have untested edges.

Where

  • test/cli.test.ts:210-217: the "--files lints only the named files (relative or absolute ...)" test passes only absolute paths.
  • test/cli.test.ts:238-242: the --changed-since test returns, and so passes, if git init throws. Its commits also lack -c commit.gpgsign=false, so a developer with global commit signing enabled gets a confusing failure.
  • test/entry.test.ts:50,57,64,73: the built-CLI exit-code tests call ctx.skip() when dist/cli.js is missing. Running npm test without a build silently skips the only real-process exit-code tests. CI builds first, so CI is fine.
  • src/project/godot-version.ts:6-40 and test/removed-api.test.ts:80-118.

Test cases and fixes

  • Relative --files with the cwd at the root, and with the cwd elsewhere (vi.spyOn(process, "cwd")).
  • --changed-since with the root at repo/game: only files under game/ are returned, root-relative, including untracked files.
  • --files x.gd --changed-since HEAD: the union, without duplicates.
  • A file deleted since the ref: not reported, and no crash.
  • A renamed file reports the new path.
  • A root that is not a git work tree: exit 2 with "git diff failed".
  • --changed-since=-x: rejected with exit 2.
  • Replace the bare return with ctx.skip("git unavailable"), and pass -c commit.gpgsign=false.
  • Fail loudly when CI is set and dist/ is missing, or build in a vitest globalSetup.
  • config/features=PackedStringArray("4.10"): ordering is numeric. "4.3", "4.5" gives "4.5".
  • "5.0": pin the behaviour. Today it maps to "4.5" and applies the 4.x DB to Godot 5; it should probably be null or warn.
  • An unparseable project.godot gives godotVersion: null and does not throw.

Getting started

  • Relevant files: test/cli.test.ts, test/entry.test.ts, test/removed-api.test.ts
  • How to run tests: npm run build && npm test

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|test/cli.test.ts|--files/--changed-since

主要言語
TypeScript
スター
0
フォーク
6
平均マージ
1日 21時間
マージ済み PR(30日)
8

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TMHSDigital/godot-correctness-mcp のほかの issue

TMHSDigital/godot-correctness-mcp の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。