Vacuous CLI tests and untested --files, --changed-since, targetVersion edges
Los mantenedores suelen responder en 2 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 68/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- godot, typescript
- Área
- cli, testing-qa
Línea de trabajo
Start with the listed cases in test/cli.test.ts, test/entry.test.ts, and test/removed-api.test.ts, then read the related CLI and version inference code in src/project/godot-version.ts. Run npm run build && npm test and check how the tests handle relative paths, Git errors, skipped built CLI tests, and version parsing. Done when the listed edge cases are covered and the tests run or skip with clear reasons.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Several CLI tests claim more than they check or can pass without running anything, and --files, --changed-since and targetVersion inference have untested edges.
Where
test/cli.test.ts:210-217: the "--files lints only the named files (relative or absolute ...)" test passes only absolute paths.test/cli.test.ts:238-242: the--changed-sincetestreturns, and so passes, ifgit initthrows. Its commits also lack-c commit.gpgsign=false, so a developer with global commit signing enabled gets a confusing failure.test/entry.test.ts:50,57,64,73: the built-CLI exit-code tests callctx.skip()whendist/cli.jsis missing. Runningnpm testwithout a build silently skips the only real-process exit-code tests. CI builds first, so CI is fine.src/project/godot-version.ts:6-40andtest/removed-api.test.ts:80-118.
Test cases and fixes
- Relative
--fileswith the cwd at the root, and with the cwd elsewhere (vi.spyOn(process, "cwd")). -
--changed-sincewith the root atrepo/game: only files undergame/are returned, root-relative, including untracked files. -
--files x.gd --changed-since HEAD: the union, without duplicates. - A file deleted since the ref: not reported, and no crash.
- A renamed file reports the new path.
- A root that is not a git work tree: exit 2 with "git diff failed".
-
--changed-since=-x: rejected with exit 2. - Replace the bare
returnwithctx.skip("git unavailable"), and pass-c commit.gpgsign=false. - Fail loudly when
CIis set anddist/is missing, or build in a vitestglobalSetup. -
config/features=PackedStringArray("4.10"): ordering is numeric."4.3", "4.5"gives"4.5". -
"5.0": pin the behaviour. Today it maps to"4.5"and applies the 4.x DB to Godot 5; it should probably benullor warn. - An unparseable
project.godotgivesgodotVersion: nulland does not throw.
Getting started
- Relevant files:
test/cli.test.ts,test/entry.test.ts,test/removed-api.test.ts - How to run tests:
npm run build && npm test
Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: testing|test/cli.test.ts|--files/--changed-since
- Lenguaje dominante
- TypeScript
- Estrellas
- 0
- Forks
- 6
- Merge medio
- 1 d 21 h
- PR fusionados (30 d)
- 8
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de TMHSDigital/godot-correctness-mcp
-
enhancement good first issue severity: medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
TMHSDigital/godot-correctness-mcp#123 ·
Los mantenedores suelen responder en 2 días
-
dependencies good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
TMHSDigital/godot-correctness-mcp#116 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
TMHSDigital/godot-correctness-mcp#107 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: low
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
TMHSDigital/godot-correctness-mcp#106 ·
Los mantenedores suelen responder en 2 días
-
bug good first issue severity: medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
TMHSDigital/godot-correctness-mcp#105 ·
Los mantenedores suelen responder en 2 días
Todos los issues de TMHSDigital/godot-correctness-mcp
Issues similares
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
openclaw/openclaw#203385 · 1 comentario · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
nwverse/persona#12800 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 1 día
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
microsoft/playwright#44289 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 Medio día Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día