Launcher builds without Model K mishandle a saved K choice

Open
#216 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
desktop-dev

Research direction

Start in the launcher's profile save/load path: grep the launcher sources for the persisted model key and for the Model K / Model M identifiers, then follow how a saved choice is read at startup and how the reported active model and fallback string are produced. Read the review of #211 for the Model K launcher choice that introduced this. Done means a K-less build keeps the saved value, states plainly that it has no Model K and runs Model M, and writes exactly what it reports; verify by round-tripping a profile saved with model=K through a K-less, L-enabled and a K-less, M-only build.

Written by the indexing model from the issue text.

Description

Found by the review of #211 (Model K launcher choice). Both cases need a launcher built without Model K, so the 0.6.5 release build (built with K) is not affected.

  1. A saved K choice is silently discarded by a K-less launcher with L enabled. Opening a profile saved with model=K drops the choice without telling the player.
  2. A K-less, M-only launcher reports an unknown saved K as an active choice, and it reports a fallback that it did not write to the game files.

Expected: a K-less build keeps the saved value, says plainly that this build has no Model K and runs Model M, and writes exactly what it reports.

Dominant language
C++
Stars
12
Forks
2
Avg merge
3h 10m
Merged PRs (30d)
171

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phantoslayer21/wronggpu

All issues in phantoslayer21/wronggpu

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.