Launcher builds without Model K mishandle a saved K choice

Aberta
#216 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
62/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
cpp
Domínio
desktop-dev

Direção de pesquisa

Start in the launcher's profile save/load path: grep the launcher sources for the persisted model key and for the Model K / Model M identifiers, then follow how a saved choice is read at startup and how the reported active model and fallback string are produced. Read the review of #211 for the Model K launcher choice that introduced this. Done means a K-less build keeps the saved value, states plainly that it has no Model K and runs Model M, and writes exactly what it reports; verify by round-tripping a profile saved with model=K through a K-less, L-enabled and a K-less, M-only build.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Found by the review of #211 (Model K launcher choice). Both cases need a launcher built without Model K, so the 0.6.5 release build (built with K) is not affected.

  1. A saved K choice is silently discarded by a K-less launcher with L enabled. Opening a profile saved with model=K drops the choice without telling the player.
  2. A K-less, M-only launcher reports an unknown saved K as an active choice, and it reports a fallback that it did not write to the game files.

Expected: a K-less build keeps the saved value, says plainly that this build has no Model K and runs Model M, and writes exactly what it reports.

Linguagem predominante
C++
Estrelas
12
Forks
2
Merge médio
3h 10min
PRs com merge (30d)
171

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de phantoslayer21/wronggpu

Todas as issues de phantoslayer21/wronggpu

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.