Model M reconstruction: zero total gather weight differs between the reference and the confirmed behaviour

Open
#129 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp, python

Research direction

Start with the dec function in clean/reference/post.py, where a NaN is mapped to the low clamp value, and compare it with the NaN-propagating behaviour confirmed for Model L (see test_l_recon.py for the known-answer pattern). Then find the Model M D3D12 and HIP reconstruction kernels and establish what they output for a gather with zero total weight. Done means the reference matches the confirmed NaN propagation, with a known-answer test, and the kernel output for this case is recorded in the issue.

Written by the indexing model from the issue text.

Description

While settling Model L's reconstruction reference (#124) the behaviour for a gather whose total weight is exactly zero (extreme but finite coefficients, every tap underflows) was confirmed for both models: there is no special path, the NaN propagates, and the decode passes NaN through.

Model M's CPU reference (clean/reference/post.py, dec) instead maps a NaN to the low clamp value, so for this input the Model M reference and the confirmed behaviour give different history values.

To do:

  • state what Model M's D3D12 and HIP reconstruction kernels produce for this input (a synthetic case with zero total weight);
  • bring the reference, and if needed the kernels, to the confirmed behaviour, with a known-answer test as in Model L's test_l_recon.py.

This needs extreme coefficient values; no visible effect in a game has been reported. Refs #89

Dominant language
C++
Stars
12
Forks
2
Avg merge
3h 10m
Merged PRs (30d)
171

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phantoslayer21/wronggpu

All issues in phantoslayer21/wronggpu

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.