Model M reconstruction: zero total gather weight differs between the reference and the confirmed behaviour

Abierto
#129 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
30/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp, python

Línea de trabajo

Start with the dec function in clean/reference/post.py, where a NaN is mapped to the low clamp value, and compare it with the NaN-propagating behaviour confirmed for Model L (see test_l_recon.py for the known-answer pattern). Then find the Model M D3D12 and HIP reconstruction kernels and establish what they output for a gather with zero total weight. Done means the reference matches the confirmed NaN propagation, with a known-answer test, and the kernel output for this case is recorded in the issue.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

While settling Model L's reconstruction reference (#124) the behaviour for a gather whose total weight is exactly zero (extreme but finite coefficients, every tap underflows) was confirmed for both models: there is no special path, the NaN propagates, and the decode passes NaN through.

Model M's CPU reference (clean/reference/post.py, dec) instead maps a NaN to the low clamp value, so for this input the Model M reference and the confirmed behaviour give different history values.

To do:

  • state what Model M's D3D12 and HIP reconstruction kernels produce for this input (a synthetic case with zero total weight);
  • bring the reference, and if needed the kernels, to the confirmed behaviour, with a known-answer test as in Model L's test_l_recon.py.

This needs extreme coefficient values; no visible effect in a game has been reported. Refs #89

Lenguaje dominante
C++
Estrellas
12
Forks
2
Merge medio
3 h 10 min
PR fusionados (30 d)
171

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phantoslayer21/wronggpu

Todos los issues de phantoslayer21/wronggpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.