UI: two-line labels overlap the row below (Tax management, Special goods trade)

Open
#3,673 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

Start in runtime/ui/frame/frame.ts, at the wrap branch that splits an authored label wider than its box onto two centred lines — its comment names "Purchase amount" and "Large category" as targets. Reproduce by opening the UI gallery (apps/client-next/tools/ui-gallery) at surface:Fortress tax and breadth:specialty-buy, and compare with the Experimental "Fit window labels" row off. Done means both lines of every listed label sit inside their box without touching the neighbouring row, with the row on by default, checked across all the entries named in the issue.

Written by the indexing model from the issue text.

Description

area: client bug priority: high

Found in a full sweep of the UI gallery (apps/client-next/tools/ui-gallery). Two-line static labels wrap onto a second line that is drawn over the label in the row below.

Gallery entries:

  • surface:Fortress tax (also reach:fortress-tax-modify, reach:fortress-tax-collect): "Blacksmith's workshop" overlaps "Defending tool shop"; "Gate of Dimensions" overlaps "Specialty store".
  • breadth:specialty-buy (Special goods trade window): "Purchase amount", "Profit amount", "Selling amount" and "Trade scale" overlap each other; in the transport inventory beside it, "Total Amount" overlaps "Trade difficulty".
  • Same pattern, milder: Character panel "Phy. balance" and Stall network "Large/Medium/Small category".

To do: fix the presentation so the text stays inside its box and clear of its neighbours.

Cause found: the wrap comes from the port-only Experimental row "Fit window labels" (on by default, owner's choice 2026-10-15). runtime/ui/frame/frame.ts wraps an authored label wider than its box onto two lines centred on the box, and its comment names "Purchase amount" and "Large category" as the targets. A box sized for one line has no room for two, so the lines land on the neighbouring rows. With the row off, the original runs the label past the window's left edge instead. The fix belongs in that row: give the second line room (or shift the pair) without entering a neighbour.

Owner rule (2026-11-16): retail's own overflow and misalignment are bugs, not behaviour to copy. Fix these even where retail draws them the same way, on by default under the Experimental "Fit window labels" row (off is the original).

Dominant language
Go
Stars
97
Forks
61
Avg merge
4h 14m
Merged PRs (30d)
913

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opensro-dev/opensro

All issues in opensro-dev/opensro

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.