UI: two-line labels overlap the row below (Tax management, Special goods trade)

未关闭
#3,673 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
typescript
领域
frontend

调研方向

Start in runtime/ui/frame/frame.ts, at the wrap branch that splits an authored label wider than its box onto two centred lines — its comment names "Purchase amount" and "Large category" as targets. Reproduce by opening the UI gallery (apps/client-next/tools/ui-gallery) at surface:Fortress tax and breadth:specialty-buy, and compare with the Experimental "Fit window labels" row off. Done means both lines of every listed label sit inside their box without touching the neighbouring row, with the row on by default, checked across all the entries named in the issue.

由索引模型根据 Issue 内容生成。

描述

area: client bug priority: high

Found in a full sweep of the UI gallery (apps/client-next/tools/ui-gallery). Two-line static labels wrap onto a second line that is drawn over the label in the row below.

Gallery entries:

  • surface:Fortress tax (also reach:fortress-tax-modify, reach:fortress-tax-collect): "Blacksmith's workshop" overlaps "Defending tool shop"; "Gate of Dimensions" overlaps "Specialty store".
  • breadth:specialty-buy (Special goods trade window): "Purchase amount", "Profit amount", "Selling amount" and "Trade scale" overlap each other; in the transport inventory beside it, "Total Amount" overlaps "Trade difficulty".
  • Same pattern, milder: Character panel "Phy. balance" and Stall network "Large/Medium/Small category".

To do: fix the presentation so the text stays inside its box and clear of its neighbours.

Cause found: the wrap comes from the port-only Experimental row "Fit window labels" (on by default, owner's choice 2026-10-15). runtime/ui/frame/frame.ts wraps an authored label wider than its box onto two lines centred on the box, and its comment names "Purchase amount" and "Large category" as the targets. A box sized for one line has no room for two, so the lines land on the neighbouring rows. With the row off, the original runs the label past the window's left edge instead. The fix belongs in that row: give the second line room (or shift the pair) without entering a neighbour.

Owner rule (2026-11-16): retail's own overflow and misalignment are bugs, not behaviour to copy. Fix these even where retail draws them the same way, on by default under the Experimental "Fit window labels" row (off is the original).

主要语言
Go
星标
97
派生
61
平均合并
4 小时 14 分钟
30 天内合并 PR
913

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

opensro-dev/opensro 的其他 Issue

查看 opensro-dev/opensro 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。