UI: two-line labels overlap the row below (Tax management, Special goods trade)

Aperta
#3,673 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
frontend

Direzione di ricerca

Start in runtime/ui/frame/frame.ts, at the wrap branch that splits an authored label wider than its box onto two centred lines — its comment names "Purchase amount" and "Large category" as targets. Reproduce by opening the UI gallery (apps/client-next/tools/ui-gallery) at surface:Fortress tax and breadth:specialty-buy, and compare with the Experimental "Fit window labels" row off. Done means both lines of every listed label sit inside their box without touching the neighbouring row, with the row on by default, checked across all the entries named in the issue.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: client bug priority: high

Found in a full sweep of the UI gallery (apps/client-next/tools/ui-gallery). Two-line static labels wrap onto a second line that is drawn over the label in the row below.

Gallery entries:

  • surface:Fortress tax (also reach:fortress-tax-modify, reach:fortress-tax-collect): "Blacksmith's workshop" overlaps "Defending tool shop"; "Gate of Dimensions" overlaps "Specialty store".
  • breadth:specialty-buy (Special goods trade window): "Purchase amount", "Profit amount", "Selling amount" and "Trade scale" overlap each other; in the transport inventory beside it, "Total Amount" overlaps "Trade difficulty".
  • Same pattern, milder: Character panel "Phy. balance" and Stall network "Large/Medium/Small category".

To do: fix the presentation so the text stays inside its box and clear of its neighbours.

Cause found: the wrap comes from the port-only Experimental row "Fit window labels" (on by default, owner's choice 2026-10-15). runtime/ui/frame/frame.ts wraps an authored label wider than its box onto two lines centred on the box, and its comment names "Purchase amount" and "Large category" as the targets. A box sized for one line has no room for two, so the lines land on the neighbouring rows. With the row off, the original runs the label past the window's left edge instead. The fix belongs in that row: give the second line room (or shift the pair) without entering a neighbour.

Owner rule (2026-11-16): retail's own overflow and misalignment are bugs, not behaviour to copy. Fix these even where retail draws them the same way, on by default under the Experimental "Fit window labels" row (off is the original).

Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.