In directx12 mesh shaders example,there is an error.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- computer-graphics
Research direction
Read MeshletGenerator/Generation.cpp and the meshletize template function first. Trace the AddToMeshlet() path where candidates are refreshed and inspect the existing candidate-empty handling. Done means the reported non-full meshlet and empty-candidate case closes the meshlet without selecting a non-adjacent seed, while the DirectX 12 mesh shaders example still works.
Written by the indexing model from the issue text.
Description
In MeshletGenerator/Generation.cpp, the meshletize template function.
After you enter the area of AddToMeshlet()==True , you refresh the candidate and remark the scores.
An error occur that there is a situation that is meshlet is not full but the candidate has been empty,(which often occurs in the seed triangle is in the clusters has been clustered), you ignore the situation and run
/*
if (candidates.empty())
{
while (triIndex < triCount && checklist[triIndex])
++triIndex;
if (triIndex == triCount)
break;
candidates.push_back(std::make_pair(triIndex, 0.0f));
candidateCheck.insert(triIndex);
}
*/
so that the meshlet was added with a new seed triangle which is not adjcent to the meshlet.
so you have to change that line /* if (IsMeshletFull(maxVerts, maxPrims, *curr)) */
into if (IsMeshletFull(maxVerts, maxPrims, *curr)||candidate.empty())
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/DirectX-Graphics-Samples
-
bug samples
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in microsoft/DirectX-Graphics-Samples
Similar issues
-
CI tracking issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
espressif/esp-matter#1874 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
KavrakiLab/vamp#126 ·
-
cudev: Fix MSVC build failures with 64-bit integers (int64_t/uint64_t) in vec_traits.hppPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
opencv/opencv_contrib#4231 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MiSTer-devel/Main_MiSTer#1341 ·
Maintainers usually reply within 1 day