Use D3D12_SDK_VERSION macro consistently across samples, instead of explicitly setting the version in source files.
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- cpp
- Domain
- computer-graphics
Research direction
Start with the D3D12RaytracingHelloWorld.cpp and D3D12On7.cpp locations, then search the samples for explicit D3D12SDKVersion definitions using the numeric SDK version. Update the identified definitions to use D3D12_SDK_VERSION and verify that no samples still hard-code the version.
Written by the indexing model from the issue text.
Description
Many samples explicitly reference the d3d12 sdk version
extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = 618; }
Whenever the SDK version is updated, the source files must also be updated, which is a tedius and annoying process. If, instead, the version is set to D3D12_SDK_VERSION then samples will automatically use the correct version.
extern "C" { __declspec(dllexport) extern const UINT D3D12SDKVersion = D3D12_SDK_VERSION; }
Example locations of this: (But there are many many more!)
- Dominant language
- C++
- Stars
- 6.8k
- Forks
- 2.2k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from microsoft/DirectX-Graphics-Samples
-
bug samples
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
microsoft/DirectX-Graphics-Samples#924 · 1 comment ·
All issues in microsoft/DirectX-Graphics-Samples
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
plengauer/DXGIOutputDuplication#81 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
sudoevolve/EUI-NEO#80 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Ryan-Millard/Img2Num#681 · 2 comments ·
Maintainers usually reply within 2 days
-
upstream update
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
conan-io/conan-center-index#31098 ·
Maintainers usually reply within 2 days