Installers: a server created when its binary is already installed keeps the template's command (and three test gaps from CodeRabbit)

オープン
#2,011 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
38/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
java
領域
tooling

調査の方向性

Start with the 38 installer templates under src/main/resources/templates and trace how each check and configureServer step handles an already installed binary. Preserve user changes to the command while making the installed binary available to newly created servers. The issue also lists test gaps in #1924, #1938, and #1986; check those issues for their relevant test files and expected assertions.

索引モデルが issue の本文から書いたものです。

説明

Two leftovers from CodeRabbit's reviews of PRs merged for 0.30.0, collected so they aren't lost. Neither is new in 0.30.0, and neither blocks it.

A server created when its binary is already installed keeps the template's command

CodeRabbit noted this on #1926 (cpp_ls), but every installer works this way. The 38 installers under src/main/resources/templates set the server's command (configureServer) only in the steps that run after a download, and none in their check. So when the check finds the server already installed (for example, when a language server is created again from its template, or a second one from the same template), the download is skipped, and the new language server keeps the template's command, such as cpp_ls. That works only if the binary is on the PATH.

Suggestion: also set the command when the check finds the server installed, without overwriting a command the user has changed.

Test gaps (no change in behavior)

  • #1924: the EDT tests start with read access, so they don't show that ApplicationUtils' overloads acquire it. Assert there is no read access before each call.
  • #1938: DAPValueReadOnlyTest checks the readOnly hint, but not getModifier(). When setVariable is supported, assert that a read-only variable gets no modifier and a writable one does.
  • #1986: ConnectingServer uses InetAddress.getLoopbackAddress(), which returns ::1 only with java.net.preferIPv6Addresses=true, so the accept test covers only 127.0.0.1. Cover the IPv4 listener when the JVM prefers IPv6.
主要言語
Java
スター
360
フォーク
125
平均マージ
14時間 13分
マージ済み PR(30日)
189

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

redhat-developer/lsp4ij のほかの issue

redhat-developer/lsp4ij の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。