Semantic tokens, document links and LSP intentions hold highlighting read actions while they wait for the language server

オープン
#2,017 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
java

調査の方向性

Start with LSPSemanticTokensHighlightVisitor.getSemanticTokens, LSPDocumentLinkCollector.collect, and LSPIntentionCodeActionSupport.getCodeActionAt, then compare their waits with refreshWhenLoaded and pendingFuture as described in the issue. Check the referenced freezes and the existing behavior in #1871. Done means the highlighting passes do not hold a read lock while waiting for the language server, and resume when a reply arrives.

索引モデルが issue の本文から書いたものです。

説明

bug codeAction documentLink not reproducible performance semantic tokens

Three freezes of LSP4IJ 0.21.0 in #2014, all at startup with probable cause LONG_READ_ACTION and the IDE killed, have highlighting threads waiting for a language server while they hold the read lock, while the EDT waits for the write lock:

Report IDE Freeze Waiting in
2116064504671633408 IntelliJ IDEA 262.10968.63 44 s LSPSemanticTokensHighlightVisitor.getSemanticTokens (line 203), and four more threads in LSPDocumentLinkCollector.collect (line 79)
2108943541375074304 RustRover 262.10968.75 41 s LSPDocumentLinkCollector.collect (line 79)
2116205187730509824 IntelliJ IDEA 262.10968.63 44 s LSPIntentionCodeActionSupport.getCodeActionAt (line 154), from LSPLazyCodeActionIntentionAction.getFamilyName in ShowIntentionsPass

Each waits in ProgressIndicatorUtils.awaitWithCheckCanceled, inside a tryRunReadAction of the highlighting. The code relies on a write action cancelling the pass's progress, so that awaitWithCheckCanceled throws and the read lock is released, as the comments of LSPSemanticTokensHighlightVisitor.getSemanticTokens and LSPIntentionCodeActionSupport.getCodeActionAt say. In these reports that didn't happen for 40 s or more. awaitWithCheckCanceled checks the progress every few milliseconds, so the progress wasn't cancelled.

In 0.30.0: unchanged. The three waits are still there (lines 203 and 79, and line 170 in getCodeActionAt); 2a5d0420 only made them null-safe. #1871 stopped the EDT from waiting for intention code actions, but ShowIntentionsPass still waits in its read action. I haven't reproduced the freezes on 0.30.0 yet.

Possible fix: don't wait in the passes. Use the reply if it's there, and otherwise return and restart the highlighting when it arrives, as #1871 does on the EDT (refreshWhenLoaded) and as the document links already do after a cancellation (pendingFuture).

主要言語
Java
スター
360
フォーク
125
平均マージ
14時間 13分
マージ済み PR(30日)
189

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

redhat-developer/lsp4ij のほかの issue

redhat-developer/lsp4ij の issue をすべて見る

似ている issue

Java の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。