Installers: a server created when its binary is already installed keeps the template's command (and three test gaps from CodeRabbit)

Abierto
#2,011 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java
Área
tooling

Línea de trabajo

Start with the 38 installer templates under src/main/resources/templates and trace how each check and configureServer step handles an already installed binary. Preserve user changes to the command while making the installed binary available to newly created servers. The issue also lists test gaps in #1924, #1938, and #1986; check those issues for their relevant test files and expected assertions.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Two leftovers from CodeRabbit's reviews of PRs merged for 0.30.0, collected so they aren't lost. Neither is new in 0.30.0, and neither blocks it.

A server created when its binary is already installed keeps the template's command

CodeRabbit noted this on #1926 (cpp_ls), but every installer works this way. The 38 installers under src/main/resources/templates set the server's command (configureServer) only in the steps that run after a download, and none in their check. So when the check finds the server already installed (for example, when a language server is created again from its template, or a second one from the same template), the download is skipped, and the new language server keeps the template's command, such as cpp_ls. That works only if the binary is on the PATH.

Suggestion: also set the command when the check finds the server installed, without overwriting a command the user has changed.

Test gaps (no change in behavior)

  • #1924: the EDT tests start with read access, so they don't show that ApplicationUtils' overloads acquire it. Assert there is no read access before each call.
  • #1938: DAPValueReadOnlyTest checks the readOnly hint, but not getModifier(). When setVariable is supported, assert that a read-only variable gets no modifier and a writable one does.
  • #1986: ConnectingServer uses InetAddress.getLoopbackAddress(), which returns ::1 only with java.net.preferIPv6Addresses=true, so the accept test covers only 127.0.0.1. Cover the IPv4 listener when the JVM prefers IPv6.
Lenguaje dominante
Java
Estrellas
360
Forks
125
Merge medio
14 h 13 min
PR fusionados (30 d)
189

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de redhat-developer/lsp4ij

Todos los issues de redhat-developer/lsp4ij

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.