Installers: a server created when its binary is already installed keeps the template's command (and three test gaps from CodeRabbit)

Aperta
#2,011 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java
Ambito
tooling

Direzione di ricerca

Start with the 38 installer templates under src/main/resources/templates and trace how each check and configureServer step handles an already installed binary. Preserve user changes to the command while making the installed binary available to newly created servers. The issue also lists test gaps in #1924, #1938, and #1986; check those issues for their relevant test files and expected assertions.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Two leftovers from CodeRabbit's reviews of PRs merged for 0.30.0, collected so they aren't lost. Neither is new in 0.30.0, and neither blocks it.

A server created when its binary is already installed keeps the template's command

CodeRabbit noted this on #1926 (cpp_ls), but every installer works this way. The 38 installers under src/main/resources/templates set the server's command (configureServer) only in the steps that run after a download, and none in their check. So when the check finds the server already installed (for example, when a language server is created again from its template, or a second one from the same template), the download is skipped, and the new language server keeps the template's command, such as cpp_ls. That works only if the binary is on the PATH.

Suggestion: also set the command when the check finds the server installed, without overwriting a command the user has changed.

Test gaps (no change in behavior)

  • #1924: the EDT tests start with read access, so they don't show that ApplicationUtils' overloads acquire it. Assert there is no read access before each call.
  • #1938: DAPValueReadOnlyTest checks the readOnly hint, but not getModifier(). When setVariable is supported, assert that a read-only variable gets no modifier and a writable one does.
  • #1986: ConnectingServer uses InetAddress.getLoopbackAddress(), which returns ::1 only with java.net.preferIPv6Addresses=true, so the accept test covers only 127.0.0.1. Cover the IPv4 listener when the JVM prefers IPv6.
Lingua principale
Java
Stelle
360
Fork
125
Merge medio
14h 13m
PR unite (30g)
189

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di redhat-developer/lsp4ij

Tutte le issue di redhat-developer/lsp4ij

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.