veche: seats can win REVISE on a scenario a retained check already catches

オープン
  • 何か問題がありますか？
#2,238 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
64/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
python
領域
devtools, testing-qa

調査の方向性

Start by reading the shared seat instructions in veche.py and the files in scripts/lenses/ to see how the calibration prompt is assembled. Then find the fixture coverage for the two acceptance cases: a retained check catches the objection, and an uncovered scenario remains actionable. Done when the first yields PASS_TO_USER with a note and the second yields REVISE.

索引モデルが issue の本文から書いたものです。

説明

Problem. The idea-critic calibration rule does not reach veche's seats, so a seat can win REVISE on a failure scenario that a check still in the packet already catches. The skill says REVISE needs a concrete scenario and that "if the evidence, the tests or the kill criterion already cover it, it is a note". The shared seat instructions in veche.py and the files in scripts/lenses/ carry no such rule.

Evidence, one run. The claim was that a UI test may drop its scroll-offset check for one scenario, where the code under test must scroll. The test keeps a second check on the element's on-screen position, on the next line of the packet.

  • Two of three seats voted REVISE, confidence 0.356. One said a component that stops compensating "cannot be caught" by the offset check. A wrong scroll moves the on-screen position, so the retained check fails in that case.
  • The citation check passed because the quotes were verbatim. It verifies the quote, not the reasoning.
  • The objection held one real point: the exemption also covered a step where no scroll is expected. An inline read had missed that, so keep this signal.

Proposal. Add the calibration rule to the seat prompt. A REVISE or HOLD claim names the input or state, the bad outcome, and the existing check that should catch it and why it does not. A claim without those counts as a note.

Acceptance. A fixture whose only objection is caught by a retained check gives PASS_TO_USER with a note. A fixture with an uncovered scenario still gives REVISE.

主要言語
Python
スター
2
フォーク
1
平均マージ
1時間 29分
マージ済み PR（30日）
567

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

protocol/perun のほかの issue

protocol/perun の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。