veche: seats can win REVISE on a scenario a retained check already catches

Abierto
  • ¿Algo no está bien?
#2,238 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
64/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
devtools, testing-qa

Línea de trabajo

Start by reading the shared seat instructions in veche.py and the files in scripts/lenses/ to see how the calibration prompt is assembled. Then find the fixture coverage for the two acceptance cases: a retained check catches the objection, and an uncovered scenario remains actionable. Done when the first yields PASS_TO_USER with a note and the second yields REVISE.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem. The idea-critic calibration rule does not reach veche's seats, so a seat can win REVISE on a failure scenario that a check still in the packet already catches. The skill says REVISE needs a concrete scenario and that "if the evidence, the tests or the kill criterion already cover it, it is a note". The shared seat instructions in veche.py and the files in scripts/lenses/ carry no such rule.

Evidence, one run. The claim was that a UI test may drop its scroll-offset check for one scenario, where the code under test must scroll. The test keeps a second check on the element's on-screen position, on the next line of the packet.

  • Two of three seats voted REVISE, confidence 0.356. One said a component that stops compensating "cannot be caught" by the offset check. A wrong scroll moves the on-screen position, so the retained check fails in that case.
  • The citation check passed because the quotes were verbatim. It verifies the quote, not the reasoning.
  • The objection held one real point: the exemption also covered a step where no scroll is expected. An inline read had missed that, so keep this signal.

Proposal. Add the calibration rule to the seat prompt. A REVISE or HOLD claim names the input or state, the bad outcome, and the existing check that should catch it and why it does not. A claim without those counts as a note.

Acceptance. A fixture whose only objection is caught by a retained check gives PASS_TO_USER with a note. A fixture with an uncovered scenario still gives REVISE.

Lenguaje dominante
Python
Estrellas
2
Forks
1
Merge medio
1 h 29 min
PR fusionados (30 d)
567

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de protocol/perun

Todos los issues de protocol/perun

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.