veche: seats can win REVISE on a scenario a retained check already catches

Aperta
  • Qualcosa non va?
#2,238 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
64/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
devtools, testing-qa

Direzione di ricerca

Start by reading the shared seat instructions in veche.py and the files in scripts/lenses/ to see how the calibration prompt is assembled. Then find the fixture coverage for the two acceptance cases: a retained check catches the objection, and an uncovered scenario remains actionable. Done when the first yields PASS_TO_USER with a note and the second yields REVISE.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem. The idea-critic calibration rule does not reach veche's seats, so a seat can win REVISE on a failure scenario that a check still in the packet already catches. The skill says REVISE needs a concrete scenario and that "if the evidence, the tests or the kill criterion already cover it, it is a note". The shared seat instructions in veche.py and the files in scripts/lenses/ carry no such rule.

Evidence, one run. The claim was that a UI test may drop its scroll-offset check for one scenario, where the code under test must scroll. The test keeps a second check on the element's on-screen position, on the next line of the packet.

  • Two of three seats voted REVISE, confidence 0.356. One said a component that stops compensating "cannot be caught" by the offset check. A wrong scroll moves the on-screen position, so the retained check fails in that case.
  • The citation check passed because the quotes were verbatim. It verifies the quote, not the reasoning.
  • The objection held one real point: the exemption also covered a step where no scroll is expected. An inline read had missed that, so keep this signal.

Proposal. Add the calibration rule to the seat prompt. A REVISE or HOLD claim names the input or state, the bad outcome, and the existing check that should catch it and why it does not. A claim without those counts as a note.

Acceptance. A fixture whose only objection is caught by a retained check gives PASS_TO_USER with a note. A fixture with an uncovered scenario still gives REVISE.

Lingua principale
Python
Stelle
2
Fork
1
Merge medio
1h 29m
PR unite (30g)
567

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di protocol/perun

Tutte le issue di protocol/perun

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.