[Bug]: iMIP mails are sent before the calendar object is stored and are not rolled back if the PUT fails

オープン
#66,571 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
php
領域
backend

調査の方向性

Start from the scheduling path the payload names: scheduleLocalDelivery, updateCalendarObject() and CalDavBackend::getDenormalizedData(), then the calendarObjectChange hook and dispatchSchedulingResponses on afterWriteContent / afterCreateFile. Confirm that iMIP mail is sent before the write succeeds. Done means mail is queued during the change and sent only after a successful write, so a rejected PUT sends nothing. Check against the reproduction steps in the issue.

索引モデルが issue の本文から書いたものです。

説明

0. Needs triage 33-feedback bug feature: caldav
⚠️ This issue respects the following points: ⚠️
  • This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
  • This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
  • I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
  • I agree to follow Nextcloud's Code of Conduct.
  • I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description

Scheduling (iTIP/iMIP) runs before the calendar object is stored. If the PUT
fails afterwards, the request is rejected, but the mails already sent are not
rolled back. A CalDAV client that retries the rejected PUT sends the same
invitations again on every retry.

Seen in production on 33.0.10, triggered by #64268: the organizer adds an
attendee to a single occurrence of a recurring event. Local delivery of the
attendee copy throws in CalDavBackend::getDenormalizedData(), the PUT returns
400, but attendees handled earlier in the delivery loop have already been
mailed. macOS Calendar retried the PUT every 17-19 minutes, with no way for the
user to discard the change, so attendees received the same invitation
repeatedly.

#64315 fixes that specific trigger. The underlying behaviour remains for any
other exception thrown after the first delivery (attendee local delivery,
backend validation, storage errors).

Steps to reproduce
  1. On 33.0.10, User A creates a recurring event with attendees B and C.
  2. In macOS Calendar, User A adds attendee D to a single occurrence.
  3. The PUT returns 400 (A valid calendar object must contain at least one VJOURNAL, VEVENT, or VTODO component type).
  4. Invitation mails have been sent anyway, and are sent again on each client retry.

On fixed versions, any exception during scheduleLocalDelivery or in
updateCalendarObject() should reproduce the same effect.

Expected behavior

A rejected PUT sends no mail. For example, collect iMIP messages during
calendarObjectChange and send them only after the write succeeded
(afterWriteContent / afterCreateFile, where
dispatchSchedulingResponses already hooks in).

Nextcloud Server version

33

Additional info
  • Related: #64268, #64315, #66192
  • Client: macOS Calendar (CalDAV)
  • Redacted logs and request trace available on request
主要言語
PHP
スター
37.5k
フォーク
5.4k
平均マージ
1日 13時間
マージ済み PR(30日)
639

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

nextcloud/server のほかの issue

nextcloud/server の issue をすべて見る

似ている issue

PHP の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。