[Bug]: iMIP mails are sent before the calendar object is stored and are not rolled back if the PUT fails
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 35/100
Rechercherichtung
Start from the scheduling path the payload names: scheduleLocalDelivery, updateCalendarObject() and CalDavBackend::getDenormalizedData(), then the calendarObjectChange hook and dispatchSchedulingResponses on afterWriteContent / afterCreateFile. Confirm that iMIP mail is sent before the write succeeds. Done means mail is queued during the change and sent only after a successful write, so a rejected PUT sends nothing. Check against the reproduction steps in the issue.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
⚠️ This issue respects the following points: ⚠️
- This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
- This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
- I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
- I agree to follow Nextcloud's Code of Conduct.
- I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description
Scheduling (iTIP/iMIP) runs before the calendar object is stored. If the PUT
fails afterwards, the request is rejected, but the mails already sent are not
rolled back. A CalDAV client that retries the rejected PUT sends the same
invitations again on every retry.
Seen in production on 33.0.10, triggered by #64268: the organizer adds an
attendee to a single occurrence of a recurring event. Local delivery of the
attendee copy throws in CalDavBackend::getDenormalizedData(), the PUT returns
400, but attendees handled earlier in the delivery loop have already been
mailed. macOS Calendar retried the PUT every 17-19 minutes, with no way for the
user to discard the change, so attendees received the same invitation
repeatedly.
#64315 fixes that specific trigger. The underlying behaviour remains for any
other exception thrown after the first delivery (attendee local delivery,
backend validation, storage errors).
Steps to reproduce
- On 33.0.10, User A creates a recurring event with attendees B and C.
- In macOS Calendar, User A adds attendee D to a single occurrence.
- The PUT returns 400 (
A valid calendar object must contain at least one VJOURNAL, VEVENT, or VTODO component type). - Invitation mails have been sent anyway, and are sent again on each client retry.
On fixed versions, any exception during scheduleLocalDelivery or in
updateCalendarObject() should reproduce the same effect.
Expected behavior
A rejected PUT sends no mail. For example, collect iMIP messages during
calendarObjectChange and send them only after the write succeeded
(afterWriteContent / afterCreateFile, where
dispatchSchedulingResponses already hooks in).
Nextcloud Server version
33
Additional info
- Related: #64268, #64315, #66192
- Client: macOS Calendar (CalDAV)
- Redacted logs and request trace available on request
- Vorherrschende Sprache
- PHP
- Sterne
- 37.5k
- Forks
- 5.4k
- Ø Merge
- 1 T. 13 Std.
- Gemergte PRs (30 T.)
- 639
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus nextcloud/server
-
35-feedback
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
0. Needs triage 35-feedback bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
Maintainer antworten meist innerhalb von 1 Tag
-
workflowengine: File entity reuses the node of the first "Tag assigned" event for all later events in the same processEvtl. vergeben @lazerg hat das vor 2 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
Maintainer antworten meist innerhalb von 1 Tag
-
Contacts import aborts with TypeError when vCards have no UID (TextImporter structure)Evtl. vergeben @SebastianKrupinski hat das vor 6 Tagen übernommen. Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
nextcloud/server#66486 · 2 Kommentare · 2 Reaktionen · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
Unified search: screen reader hears "No matching results" on mobile even when there are resultsEvtl. vergeben @lazerg hat das vor 10 Tagen übernommen. Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in nextcloud/server
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
TYPO3-Solr/ext-solr#4850 ·
Maintainer antworten meist innerhalb von 2 Tagen
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Offensync-en
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Offensync-en
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
Maintainer antworten meist innerhalb von 1 Tag
-
Перевод устарел
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
glpi-project/glpi#26353 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag