[Bug]: Unified search returns HTTP 500 on PHP 8 when the `cursor` parameter is empty ("Unsupported operand types: string + int")

オープン 初心者向け
#66,623 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
66/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
php
領域
backend

調査の方向性

クラッシュ箇所は5つあり、表に記載されています: apps/files/lib/Search/FilesSearchProvider.php(143行目付近)、apps/dav/lib/Search/ContactsSearchProvider.php、apps/dav/lib/Search/EventsSearchProvider.php、apps/dav/lib/Search/TasksSearchProvider.php、apps/systemtags/lib/Search/TagSearchProvider.php。まず、プロバイダー検索エンドポイントに空の cursor を指定して500エラーを再現してください。その後、各プロバイダーが getCursor() から次のカーソルをどこで計算しているかを特定してください。空のカーソルがすべてのプロバイダーで200を返し、メンテナーがプロバイダーごとのキャストと SearchQuery::getCursor() での正規化のどちらにするかを選んだ時点で完了です。

索引モデルが issue の本文から書いたものです。

説明

0. Needs triage 35-feedback bug
⚠️ This issue respects the following points: ⚠️
  • This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
  • This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
  • I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
  • I agree to follow Nextcloud's Code of Conduct.
  • I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description

Unified search is completely broken on PHP 8: every search request returns HTTP 500 and the UI shows "No matches found" even when matching files exist.

Every search provider computes the next cursor as:

$query->getCursor() + <int>

When the web frontend sends an empty cursor query parameter (which it does on the first search), getCursor() returns an empty string. On PHP 8, '' + int throws a TypeError instead of coercing to 0 as PHP 7 did. The provider crashes, the OCS endpoint returns 500, and the frontend - which receives an error rather than an empty result set - renders "No matches found".

This affects five providers across three apps, so file, contacts, calendar, tasks and tag search all break at once. Because unified search queries every provider, a single failing one is enough to make the whole search look empty.

File Line Code
apps/files/lib/Search/FilesSearchProvider.php 143 $query->getCursor() + $query->getLimit()
apps/dav/lib/Search/ContactsSearchProvider.php 130 $query->getCursor() + count($formattedResults)
apps/dav/lib/Search/EventsSearchProvider.php 207 $query->getCursor() + count($uniqueResults)
apps/dav/lib/Search/TasksSearchProvider.php 139 $query->getCursor() + count($searchResults)
apps/systemtags/lib/Search/TagSearchProvider.php 149 $query->getCursor() + $query->getLimit()
Steps to reproduce
  1. Run Nextcloud 35.x on PHP 8 (reproduced on PHP 8.5.4).
  2. Log in to the web UI and open the Files app.
  3. Type into the unified search bar any term matching an existing file.
  4. The dropdown shows "No matches found" even though the file exists.
  5. The browser console shows: unified-search: Unexpected AxiosError "Request failed with status code 500".

The failure can be isolated with direct requests. The empty cursor is the only variable that changes between 200 and 500:

# 200, returns results:
/ocs/v2.php/search/providers/files/search?term=<term>&from=%2Fapps%2Ffiles%2Ffiles

# 200, returns results:
/ocs/v2.php/search/providers/files/search?term=<term>&from=%2Fapps%2Ffiles%2Ffiles&cursor=0

# 500:
/ocs/v2.php/search/providers/files/search?term=<term>&from=%2Fapps%2Ffiles%2Ffiles&cursor=
Expected behavior

An empty cursor should be treated as "no cursor" (i.e. 0) and the search should return results normally, as it did on PHP 7.

Actual behaviour: the provider throws, the endpoint returns HTTP 500, and the UI reports no matches.

Nextcloud Server version

35

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.5

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?
  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other
Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs
Exception: Unsupported operand types: string + int in file
'/var/www/html/apps/dav/lib/Search/EventsSearchProvider.php' line 207

URL: /ocs/v2.php/search/providers/calendar/search?term=<term>&from=%2Fapps%2Ffiles%2Ffiles&cursor=

The same exception is raised by each affected provider at the line listed in the description.
Additional info
Suggested fix

Cast the cursor before the addition, so an empty value becomes 0:

(int)$query->getCursor() + $query->getLimit()

Applying that one-line change to the five files listed above restores unified search completely. Verified locally: all nine registered providers return HTTP 200 afterwards, including with &cursor= empty.

A more central alternative would be to normalise the value in SearchQuery::getCursor() itself, or when the OCS controller parses the request, so providers never receive an empty string.

Notes
  • The regression is invisible on PHP 7, where '' + int evaluates to the integer with only a notice. It only surfaces once the server runs PHP 8, which makes it easy to miss and hard for users to attribute: the search simply looks like it finds nothing.
  • Reproduced on 35.0.2 and again on 35.0.3. The 35.0.3 update overwrote a local patch and the bug returned, so the affected code is unchanged between those releases.
App versions of the affected apps
  • files: 3.0.0
  • dav: 2.0.1
  • systemtags: 2.0.0
主要言語
PHP
スター
37.5k
フォーク
5.4k
平均マージ
1日 14時間
マージ済み PR(30日)
648

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

nextcloud/server のほかの issue

nextcloud/server の issue をすべて見る

似ている issue

PHP の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。