[Bug]: iMIP mails are sent before the calendar object is stored and are not rolled back if the PUT fails

未关闭
#66,571 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
php
领域
backend

调研方向

Start from the scheduling path the payload names: scheduleLocalDelivery, updateCalendarObject() and CalDavBackend::getDenormalizedData(), then the calendarObjectChange hook and dispatchSchedulingResponses on afterWriteContent / afterCreateFile. Confirm that iMIP mail is sent before the write succeeds. Done means mail is queued during the change and sent only after a successful write, so a rejected PUT sends nothing. Check against the reproduction steps in the issue.

由索引模型根据 Issue 内容生成。

描述

0. Needs triage 33-feedback bug feature: caldav
⚠️ This issue respects the following points: ⚠️
  • This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
  • This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
  • I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
  • I agree to follow Nextcloud's Code of Conduct.
  • I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description

Scheduling (iTIP/iMIP) runs before the calendar object is stored. If the PUT
fails afterwards, the request is rejected, but the mails already sent are not
rolled back. A CalDAV client that retries the rejected PUT sends the same
invitations again on every retry.

Seen in production on 33.0.10, triggered by #64268: the organizer adds an
attendee to a single occurrence of a recurring event. Local delivery of the
attendee copy throws in CalDavBackend::getDenormalizedData(), the PUT returns
400, but attendees handled earlier in the delivery loop have already been
mailed. macOS Calendar retried the PUT every 17-19 minutes, with no way for the
user to discard the change, so attendees received the same invitation
repeatedly.

#64315 fixes that specific trigger. The underlying behaviour remains for any
other exception thrown after the first delivery (attendee local delivery,
backend validation, storage errors).

Steps to reproduce
  1. On 33.0.10, User A creates a recurring event with attendees B and C.
  2. In macOS Calendar, User A adds attendee D to a single occurrence.
  3. The PUT returns 400 (A valid calendar object must contain at least one VJOURNAL, VEVENT, or VTODO component type).
  4. Invitation mails have been sent anyway, and are sent again on each client retry.

On fixed versions, any exception during scheduleLocalDelivery or in
updateCalendarObject() should reproduce the same effect.

Expected behavior

A rejected PUT sends no mail. For example, collect iMIP messages during
calendarObjectChange and send them only after the write succeeded
(afterWriteContent / afterCreateFile, where
dispatchSchedulingResponses already hooks in).

Nextcloud Server version

33

Additional info
  • Related: #64268, #64315, #66192
  • Client: macOS Calendar (CalDAV)
  • Redacted logs and request trace available on request
主要语言
PHP
星标
37.5k
派生
5.4k
平均合并
1 天 13 小时
30 天内合并 PR
639

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

nextcloud/server 的其他 Issue

查看 nextcloud/server 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。