AgentTool runs the wrapped agent with the default RunConfig instead of the caller's
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 72/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- java
調査の方向性
Start at AgentTool.runAsync and trace how the caller's RunConfig reaches the nested Runner. Use AgentToolTest, including call_propagatesCallerRunConfig, and the TestLlm utilities in core/src/test/java/com/google/adk/testing. Done means the wrapped agent receives the caller's limits, tool mode, and metadata, uses the expected streaming mode, and the tests stop the nested run at the configured limit.
索引モデルが issue の本文から書いたものです。
説明
🔴 Required Information
Describe the Bug:
AgentTool.runAsync starts the wrapped agent with Runner.runAsync(userId, sessionId, content), the overload that uses RunConfig.builder().build(). So an agent used as a tool always runs with the RunConfig defaults (maxLlmCalls 500, ToolExecutionMode.NONE, empty customMetadata), whatever RunConfig the caller passed to Runner.runAsync. A maxLlmCalls limit set to bound one request does not bound the LLM calls of an agent behind an AgentTool, and toolExecutionMode(SEQUENTIAL) does not reach that agent's tool calls.
Steps to Reproduce:
- Check out
main(4092a1f). - Give a root
LlmAgentanAgentToolthat wraps a secondLlmAgentwhose model keeps calling one of its tools. - Run the root agent with
runner.runAsync(userId, sessionId, message, RunConfig.builder().maxLlmCalls(5).build()).
Expected Behavior:
The wrapped agent runs under the caller's RunConfig, so the run stops once the wrapped agent has made 5 LLM calls. adk-python does this since google/adk-python@983c280 ("fix(tools): run an agent tool under the caller's RunConfig"), and runs the wrapped agent in StreamingMode.NONE since google/adk-python@0d5752b, because only the last event of the nested run becomes the tool result.
Observed Behavior:
The wrapped agent gets the default RunConfig. With test doubles for both models (code below), the root agent made 1 LLM call and the wrapped agent 500 before the run failed with LlmCallsLimitExceededException: Max number of llm calls limit of 500 exceeded.
(When the wrapped agent's test model answers on the calling thread instead, main fails earlier with a StackOverflowError, after about 270–290 nested calls in my runs. With the fix, both variants stop after 5.)
Environment Details:
- ADK Library Version (see maven dependency):
mainat4092a1f; the v1.10.1 release has the sameAgentToolcode.AgentToolhas called the three-argumentrunAsyncsince it was added in 0.1.0. - OS: Windows 11 (not OS-specific)
- TS Version (tsc --version): N/A (Java: Microsoft OpenJDK 17.0.19; Maven 4.0.0-rc-3 via
mvnw)
Model Information:
- Which model is being used: N/A (reproduced with
TestLlm; the call path does not depend on the model)
🟡 Optional Information
Regression:
No.
Logs:
What the wrapped agent receives, from the unit test in the fix (it wraps a test agent that records its InvocationContext; the caller's RunConfig has toolExecutionMode(SEQUENTIAL), maxLlmCalls(7) and customMetadata {tier=x}), run against main:
[ERROR] AgentToolTest.call_propagatesCallerRunConfig:896 value of: runConfig()
expected: …, toolExecutionMode=SEQUENTIAL, outputAudioTranscription=null, inputAudioTranscription=null, maxLlmCalls=7, autoCreateSession=false, groupFunctionResponsesInHistoryOverride=Optional.empty, customMetadata={tier=x}}
but was : …, toolExecutionMode=NONE, outputAudioTranscription=null, inputAudioTranscription=null, maxLlmCalls=500, autoCreateSession=false, groupFunctionResponsesInHistoryOverride=Optional.empty, customMetadata={}}
Additional Context:
The nested Runner creates its own InvocationContext, so passing the caller's RunConfig bounds the wrapped agent's LLM calls separately from the caller's; that is also how adk-python counts them. I have a fix with unit tests ready and will link the PR here.
Minimal Reproduction Code:
// The wrapped agent's model always asks for echo_tool again. It answers on an RxJava IO thread
// so that the loop on main reaches the LLM-call limit instead of overflowing the stack first.
TestLlm workerLlm =
createTestLlm(
() ->
Flowable.just(
createFunctionCallLlmResponse(
"worker-call", "echo_tool", ImmutableMap.of("arg", "x")))
.subscribeOn(Schedulers.io()));
LlmAgent worker =
LlmAgent.builder()
.name("worker")
.description("Keeps calling echo_tool.")
.model(workerLlm)
.tools(new EchoTool())
.build();
TestLlm rootLlm =
createTestLlm(
createFunctionCallLlmResponse("root-call", "worker", ImmutableMap.of("request", "go")),
createTextLlmResponse("done"));
LlmAgent root =
LlmAgent.builder().name("root").model(rootLlm).tools(AgentTool.create(worker)).build();
InMemoryRunner runner = new InMemoryRunner(root);
Session session = runner.sessionService().createSession(runner.appName(), "user").blockingGet();
runner
.runAsync(
"user",
session.id(),
Content.fromParts(Part.fromText("hi")),
RunConfig.builder().maxLlmCalls(5).build())
.toList()
.blockingGet();
// Fails with "Max number of llm calls limit of 500 exceeded";
// workerLlm.getRequests().size() is 500, not 5.
(createTestLlm, createFunctionCallLlmResponse, createTextLlmResponse and the nested EchoTool class are in TestUtils, next to TestLlm in core/src/test/java/com/google/adk/testing; Schedulers is io.reactivex.rxjava3.schedulers.Schedulers.)
How often has this issue occurred?:
- Always (100%)
- 主要言語
- Java
- スター
- 1.7k
- フォーク
- 421
- 平均マージ
- 3日 9時間
- マージ済み PR(30日)
- 29
環境構築
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
google/adk-java のほかの issue
-
needs review
難易度 4/5 3〜5日 初心者へのやさしさ 68/100
google/adk-java#1564 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Approved tool call re-runs on every later user turn if it never got a function response対応中かも @hemasekhar-p が 4 日前に担当しました。 オープンneeds review
google/adk-java#1556 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
LocalSkillSource.listResources returns backslash-separated paths on Windows対応中かも @hemasekhar-p が 4 日前に担当しました。 オープンneeds review
google/adk-java#1541 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Context caching (ContextCacheConfig) is a silent no-op: config is plumbed to InvocationContext but never read対応中かも @hemasekhar-p が 6 日前に担当しました。 オープンneeds review
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
google/adk-java#1530 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
MCP toolset: in-model built-ins (e.g. google_search) can be shadowed by a server tool; a server tool named set_model_response aborts the run対応中かも @hemasekhar-p が 12 日前に担当しました。 オープンneeds review
google/adk-java#1513 · コメント 2 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
google/adk-java の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
-
feature triaged
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
Graylog2/graylog2-server#27549 ·
メンテナーはふだん 1 日以内に返信
-
component/zeebe kind/bug
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
UniversalMediaServer/UniversalMediaServer#6356 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
googleapis/google-cloud-java#14533 ·
メンテナーはふだん 1 日以内に返信