AgentTool runs the wrapped agent with the default RunConfig instead of the caller's
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- java
调研方向
Start at AgentTool.runAsync and trace how the caller's RunConfig reaches the nested Runner. Use AgentToolTest, including call_propagatesCallerRunConfig, and the TestLlm utilities in core/src/test/java/com/google/adk/testing. Done means the wrapped agent receives the caller's limits, tool mode, and metadata, uses the expected streaming mode, and the tests stop the nested run at the configured limit.
由索引模型根据 Issue 内容生成。
描述
🔴 Required Information
Describe the Bug:
AgentTool.runAsync starts the wrapped agent with Runner.runAsync(userId, sessionId, content), the overload that uses RunConfig.builder().build(). So an agent used as a tool always runs with the RunConfig defaults (maxLlmCalls 500, ToolExecutionMode.NONE, empty customMetadata), whatever RunConfig the caller passed to Runner.runAsync. A maxLlmCalls limit set to bound one request does not bound the LLM calls of an agent behind an AgentTool, and toolExecutionMode(SEQUENTIAL) does not reach that agent's tool calls.
Steps to Reproduce:
- Check out
main(4092a1f). - Give a root
LlmAgentanAgentToolthat wraps a secondLlmAgentwhose model keeps calling one of its tools. - Run the root agent with
runner.runAsync(userId, sessionId, message, RunConfig.builder().maxLlmCalls(5).build()).
Expected Behavior:
The wrapped agent runs under the caller's RunConfig, so the run stops once the wrapped agent has made 5 LLM calls. adk-python does this since google/adk-python@983c280 ("fix(tools): run an agent tool under the caller's RunConfig"), and runs the wrapped agent in StreamingMode.NONE since google/adk-python@0d5752b, because only the last event of the nested run becomes the tool result.
Observed Behavior:
The wrapped agent gets the default RunConfig. With test doubles for both models (code below), the root agent made 1 LLM call and the wrapped agent 500 before the run failed with LlmCallsLimitExceededException: Max number of llm calls limit of 500 exceeded.
(When the wrapped agent's test model answers on the calling thread instead, main fails earlier with a StackOverflowError, after about 270–290 nested calls in my runs. With the fix, both variants stop after 5.)
Environment Details:
- ADK Library Version (see maven dependency):
mainat4092a1f; the v1.10.1 release has the sameAgentToolcode.AgentToolhas called the three-argumentrunAsyncsince it was added in 0.1.0. - OS: Windows 11 (not OS-specific)
- TS Version (tsc --version): N/A (Java: Microsoft OpenJDK 17.0.19; Maven 4.0.0-rc-3 via
mvnw)
Model Information:
- Which model is being used: N/A (reproduced with
TestLlm; the call path does not depend on the model)
🟡 Optional Information
Regression:
No.
Logs:
What the wrapped agent receives, from the unit test in the fix (it wraps a test agent that records its InvocationContext; the caller's RunConfig has toolExecutionMode(SEQUENTIAL), maxLlmCalls(7) and customMetadata {tier=x}), run against main:
[ERROR] AgentToolTest.call_propagatesCallerRunConfig:896 value of: runConfig()
expected: …, toolExecutionMode=SEQUENTIAL, outputAudioTranscription=null, inputAudioTranscription=null, maxLlmCalls=7, autoCreateSession=false, groupFunctionResponsesInHistoryOverride=Optional.empty, customMetadata={tier=x}}
but was : …, toolExecutionMode=NONE, outputAudioTranscription=null, inputAudioTranscription=null, maxLlmCalls=500, autoCreateSession=false, groupFunctionResponsesInHistoryOverride=Optional.empty, customMetadata={}}
Additional Context:
The nested Runner creates its own InvocationContext, so passing the caller's RunConfig bounds the wrapped agent's LLM calls separately from the caller's; that is also how adk-python counts them. I have a fix with unit tests ready and will link the PR here.
Minimal Reproduction Code:
// The wrapped agent's model always asks for echo_tool again. It answers on an RxJava IO thread
// so that the loop on main reaches the LLM-call limit instead of overflowing the stack first.
TestLlm workerLlm =
createTestLlm(
() ->
Flowable.just(
createFunctionCallLlmResponse(
"worker-call", "echo_tool", ImmutableMap.of("arg", "x")))
.subscribeOn(Schedulers.io()));
LlmAgent worker =
LlmAgent.builder()
.name("worker")
.description("Keeps calling echo_tool.")
.model(workerLlm)
.tools(new EchoTool())
.build();
TestLlm rootLlm =
createTestLlm(
createFunctionCallLlmResponse("root-call", "worker", ImmutableMap.of("request", "go")),
createTextLlmResponse("done"));
LlmAgent root =
LlmAgent.builder().name("root").model(rootLlm).tools(AgentTool.create(worker)).build();
InMemoryRunner runner = new InMemoryRunner(root);
Session session = runner.sessionService().createSession(runner.appName(), "user").blockingGet();
runner
.runAsync(
"user",
session.id(),
Content.fromParts(Part.fromText("hi")),
RunConfig.builder().maxLlmCalls(5).build())
.toList()
.blockingGet();
// Fails with "Max number of llm calls limit of 500 exceeded";
// workerLlm.getRequests().size() is 500, not 5.
(createTestLlm, createFunctionCallLlmResponse, createTextLlmResponse and the nested EchoTool class are in TestUtils, next to TestLlm in core/src/test/java/com/google/adk/testing; Schedulers is io.reactivex.rxjava3.schedulers.Schedulers.)
How often has this issue occurred?:
- Always (100%)
- 主要语言
- Java
- 星标
- 1.7k
- 派生
- 421
- 平均合并
- 3 天 14 小时
- 30 天内合并 PR
- 31
环境准备
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
google/adk-java 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 68/100
维护者通常 1 天内回复
-
Approved tool call re-runs on every later user turn if it never got a function response可能已有人在做 @hemasekhar-p 于 2 天前认领。 未关闭needs review
google/adk-java#1556 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
LocalSkillSource.listResources returns backslash-separated paths on Windows可能已有人在做 @hemasekhar-p 于 3 天前认领。 未关闭needs review
google/adk-java#1541 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Context caching (ContextCacheConfig) is a silent no-op: config is plumbed to InvocationContext but never read可能已有人在做 @hemasekhar-p 于 4 天前认领。 未关闭needs review
难度 5/5 一周以上 新手友好度 35/100
google/adk-java#1530 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
MCP toolset: in-model built-ins (e.g. google_search) can be shadowed by a server tool; a server tool named set_model_response aborts the run可能已有人在做 @hemasekhar-p 于 11 天前认领。 未关闭needs review
google/adk-java#1513 · 2 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
OpenAPITools/openapi-generator#25014 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
openhab/openhab-core#5847 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
-
难度 2/5 1-3 小时 新手友好度 88/100
apache/parquet-java#3820 ·
维护者通常 1 天内回复