LocalSkillSource.listResources returns backslash-separated paths on Windows
@hemasekhar-p がすでに取り組んでいます。
2026年9月24日 から。
評価
この issue はまだ評価されていません。
説明
🔴 Required Information
Describe the Bug:
LocalSkillSource.listResources(skillName, resourceDirectory) turns each resource path, relative to the skill directory, into a string with Path.toString(), which uses the platform separator. On Windows it returns assets\file1.txt, while ClassPathSkillSource and InMemorySkillSource return assets/file1.txt for the same skill layout. So the result of SkillSource.listResources depends on both the implementation and the OS, and LocalSkillSourceTest.testListResources fails on Windows.
Steps to Reproduce:
- On Windows, check out
main(4092a1f). - Run
./mvnw -pl core test -Dtest=LocalSkillSourceTest. testListResourcesfails; see the log below.
Expected Behavior:
[assets/file1.txt, assets/subdir/file2.txt]: /-separated paths, as ClassPathSkillSource and InMemorySkillSource return and as the test expects. adk-python keys directory-loaded skill resources the same way since google/adk-python@bc2c97c ("Key directory-loaded skill resources with forward slashes").
Observed Behavior:
[assets\file1.txt, assets\subdir\file2.txt]
Environment Details:
- ADK Library Version (see maven dependency):
mainat4092a1f(1.10.1). The code has not changed sinceLocalSkillSourcewas added in 1.3.0. - OS: Windows 11
- TS Version (tsc --version): N/A (Java: Microsoft OpenJDK 17.0.19; Maven 4.0.0-rc-3 via
mvnw)
Model Information:
- Which model is being used: N/A
🟡 Optional Information
Regression:
No. LocalSkillSource has used Path.toString() here since it was added in 1.3.0.
Logs:
[ERROR] Failures:
[ERROR] LocalSkillSourceTest.testListResources:96 value of : blockingGet()
missing (2) : assets/file1.txt, assets/subdir/file2.txt
unexpected (2): assets\file1.txt, assets\subdir\file2.txt
---
expected : [assets/file1.txt, assets/subdir/file2.txt]
but was : [assets\file1.txt, assets\subdir\file2.txt]
[ERROR] Tests run: 21, Failures: 1, Errors: 0, Skipped: 0
Additional Context:
CI runs only on Ubuntu, where Path.toString() already uses /, so the test passes there. I have a one-line fix ready and will link the PR here.
How often has this issue occurred?:
- Always (100%) on Windows
- 主要言語
- Java
- スター
- 1.7k
- フォーク
- 421
- 平均マージ
- 3日 10時間
- マージ済み PR(30日)
- 34
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
google/adk-java のほかの issue
-
needs review
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
-
needs review
-
needs review
-
needs review
-
needs review
google/adk-java の issue をすべて見る
似ている issue
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
objectionary/jeo-maven-plugin#1811 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
hiero-ledger/hiero-block-node#3693 ·
-
area/dependencies kind/cve severity/critical source/scan-dependencies status/triage
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
bug good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
-
proposal
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
beemdevelopment/Aegis#1840 ·