A single throw inside render() permanently stops the render loop, and a consumer cannot restart it
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 65/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- typescript, wasm
- 領域
- frontend, performance
調査の方向性
lib/terminal.ts の startRenderLoop() から始め、既存の xterm-compat getChars() の範囲ガードと併せて lib/renderer.ts:648 を調査します。term.resize() 周辺で障害を再現し、その後、レンダリング例外の発生後にループがどのように動作すべきか、またどの公開リカバリシグナルまたはエラーシグナルが適切かを判断します。完了の条件は、不正なフレームによって端末が永久に空白になることがなくなり、無効なコードポイントがガードなしで String.fromCodePoint に到達しないことです。
索引モデルが issue の本文から書いたものです。
説明
Hi! First off, thanks for ghostty-web — we run it as the terminal in dev-3.0 and it's been a pleasure to work with.
We hit a failure mode in production that I think is worth reporting separately from the individual crashes, because it turns any exception in the render path into a permanently dead terminal that the embedding app cannot recover from.
What happens
The pane goes blank and stays blank. The PTY, the shell and the process keep running, the DOM is fine, keyboard input still reaches the shell — nothing repaints, ever. Neither resizing the window nor toggling fullscreen brings it back. Only recreating the Terminal (or reloading the page) helps.
Why it is permanent
lib/terminal.ts → startRenderLoop() (current main):
private startRenderLoop(): void {
if (this.animationFrameId) return;
const loop = () => {
if (!this.isDisposed && this.isOpen) {
this.renderer!.render(this.wasmTerm!, false, this.viewportY, this, this.scrollbarOpacity);
// ...
this.animationFrameId = requestAnimationFrame(loop);
}
};
loop();
}
The next frame is scheduled only after render() returns, and the loop body has no try/catch. So one throw out of render() means no further frames — for the lifetime of that Terminal. And since startRenderLoop is private, an embedder has no way to restart it: there is no public "resume rendering" entry point and no error event to hook.
What we actually saw
Two different exceptions, both reaching us through term.resize(cols, rows), both leaving a permanently blank pane. From our logs (ghostty-web 0.4.0, macOS, Bun-based Electrobun app, WKWebView):
ERROR [refit] term.resize threw {"error":"RangeError: Arguments contain a value that is out of range of code points","cols":257,"rows":82}
ERROR [refit] term.resize threw {"error":"RuntimeError: Out of bounds memory access (evaluating 'this.exports.ghostty_terminal_resize(this.handle,e,t)')","cols":158,"rows":82}
In the second case the trap repeated ~116 times at frame cadence (a scrollbar fade animation kept calling render()), and eventually ghostty_terminal_resize itself trapped — so that WASM terminal was gone, not just one frame. Both were triggered by an ordinary resize: one right after we reattached to an existing PTY, one from a user dragging a side panel.
The first one has a plausible source that is still present on main — lib/renderer.ts:648:
char = String.fromCodePoint(cell.codepoint || 32); // Default to space if null
no range check, while the xterm-compat getChars() in the same codebase does guard the same value:
codepoint < 0 || codepoint > 0x10ffff || (codepoint >= 0xd800 && codepoint <= 0xdfff) ? "�" : String.fromCodePoint(codepoint)
So a garbage cell (for us most likely read around a resize realloc) is a replacement character in one path and a fatal, terminal-killing throw in the other.
Related, but not the same thing
- #132 fixes the resize/realloc race itself (pausing the loop around the WASM resize) — that removes one source of throws, and it is exactly what we are missing. We are on the latest npm release, 0.4.0, so we don't have it; I see #137 and #182 already cover getting a release out, so I'm not asking again here.
- #141 is another route to the same
Out of bounds memory access, fromfree()after multi-codepoint graphemes.
This report is about the layer above both: whatever the cause, one bad frame should not be able to end rendering forever with no way back.
What would help
- Survive a bad frame. Reschedule the next frame in a
finally(or wrap the body intry/catch), so an exception costs one frame instead of the terminal. Failing loudly is fine and welcome — logging or anonRenderErrorevent would be better than silence — as long as the loop stays alive. - Give embedders a way back. A public way to restart rendering (or a documented "the renderer is dead" signal) would let an app recover without throwing away the
Terminal. Today our only option is to dispose the terminal, build a new one and repaint from scratch, which is what we ended up shipping. - Range-guard the draw path in
renderer.tsthe waygetChars()already does, so a bad codepoint degrades to�instead of killing the terminal.
Happy to test a patch against our app — we see this in the wild often enough to tell quickly whether it's gone. Thanks again!
- 主要言語
- TypeScript
- スター
- 2.9k
- フォーク
- 174
- PR マージ指標
- 30日以内にマージされた PR はありません
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
coder/ghostty-web のほかの issue
-
attachCustomKeyEventHandler inverts xterm.js's return-value contract (silently swallows all input) オープン
難易度 3/5 1〜2日 初心者へのやさしさ 52/100
coder/ghostty-web#192 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 70/100
coder/ghostty-web#188 ·
-
難易度 5/5 1週間以上 初心者へのやさしさ 45/100
coder/ghostty-web#187 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
coder/ghostty-web#186 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 55/100
coder/ghostty-web#184 ·
coder/ghostty-web の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
bcgov/bc-wallet-mobile#4761 · コメント 1 件 ·
-
external-issue to-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
-
area-deployment area-integrations triage:bot-seen
難易度 2/5 半日 初心者へのやさしさ 86/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
refactor
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100