A widget package's preview stays light in a dark Settings window
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 30/100
調査の方向性
Start with Sources/StableBar/PackageDetailView.swift:185 and :414, then read Sources/StableBar/WidgetPackage.swift:14 and the referenced stablebar-packages CONTRIBUTING.md preview guidance. Compare the optional dark screenshot proposal with CI generated previews; either path changes the package format and involves both repositories. Done means Settings shows the preview matching the bar appearance, with the existing screenshot as fallback, and package validation and indexing support the chosen format.
索引モデルが issue の本文から書いたものです。
説明
Problem
A widget package's page in Settings → Store shows its Store screenshot. Authors make it by hand: 520 × 144 pixels, "the widget centered on a plain background" (stablebar-packages CONTRIBUTING.md, Preview). Every current preview is drawn in Light mode. In a dark Settings window it is a bright slab above dark rows, and it shows the widget in colors the bar won't use: Status ring's dark ring and Wi-Fi glyph turn light on a dark bar.
Themes don't have this problem: the page draws their preview for the bar's appearance (draft.themePreview?.configuration(for: appearance), Sources/StableBar/PackageDetailView.swift:185).
Proposal
Show the preview for the appearance the bar uses, and fall back to the single screenshot. There are two ways to get it, and both change the package format, so it's a maintainer's call:
- An optional dark screenshot.
package.jsongains a second path, such asscreenshotDark, and the index gains a matching URL. stablebar-packages CI checks it likescreenshot, and its README can show both with<picture>. This is the smaller change, but authors make two images by hand, and they can drift from the widget. - Previews drawn by StableBar. Store CI draws each package's widgets offscreen, as
--render-scenesdoes, in Light and Dark. It uses sample values the package declares and publishes both images. Previews then come from the real layout engine and stay current, but this needs a format for sample values and CI work in both repositories.
Drawing the preview live in Settings doesn't work today. StableBar must not run a package's providers or commands before review. WidgetSampleContent draws a widget's default layout with generic sample values, not the package's own layout (Sources/StableBar/PackageListPreview.swift:62). Status ring would show as an icon and a number, not as its ring.
Possible today
No. PackagePreview shows screenshotData before anything else (Sources/StableBar/PackageDetailView.swift:414), and the manifest and the index each have one screenshot. WidgetPackageManifest rejects unknown keys (Sources/StableBar/WidgetPackage.swift:14), so a package using a new key needs a minimumVersion at or above the release that adds it. The index ignores keys it doesn't know. Checked on origin/main at da7455a and on stablebar-packages main.
Related
- #144 / #152 added previews to the package list.
- #818 covers the page's icon, which differs from the row's.
Triaged by Claude Code (Claude Opus 5.5).
- 主要言語
- Swift
- スター
- 184
- フォーク
- 12
- 平均マージ
- 3時間 50分
- マージ済み PR(30日)
- 387
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
Seb-GRAF/StableBar のほかの issue
-
enhancement
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
メンテナーはふだん 1 日以内に返信
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display change対応中かも @Jonathanm10 が今日担当しました。 オープンneeds-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
Allow the App Menu to display the frontmost app icon対応中かも @khatami10 が今日担当しました。 オープンenhancement needs-triage
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 4/5 3〜5日 初心者へのやさしさ 54/100
メンテナーはふだん 1 日以内に返信
Seb-GRAF/StableBar の issue をすべて見る
似ている issue
-
good first issue help wanted testing
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
-
area:cli documentation good first issue priority:low
難易度 1/5 1時間未満 初心者へのやさしさ 94/100
isaaclins/freesnitch#430 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信