A widget package's preview stays light in a dark Settings window

オープン
#819 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
30/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
json, swift
領域
design, desktop

調査の方向性

Start with Sources/StableBar/PackageDetailView.swift:185 and :414, then read Sources/StableBar/WidgetPackage.swift:14 and the referenced stablebar-packages CONTRIBUTING.md preview guidance. Compare the optional dark screenshot proposal with CI generated previews; either path changes the package format and involves both repositories. Done means Settings shows the preview matching the bar appearance, with the existing screenshot as fallback, and package validation and indexing support the chosen format.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Problem

A widget package's page in Settings → Store shows its Store screenshot. Authors make it by hand: 520 × 144 pixels, "the widget centered on a plain background" (stablebar-packages CONTRIBUTING.md, Preview). Every current preview is drawn in Light mode. In a dark Settings window it is a bright slab above dark rows, and it shows the widget in colors the bar won't use: Status ring's dark ring and Wi-Fi glyph turn light on a dark bar.

Themes don't have this problem: the page draws their preview for the bar's appearance (draft.themePreview?.configuration(for: appearance), Sources/StableBar/PackageDetailView.swift:185).

Proposal

Show the preview for the appearance the bar uses, and fall back to the single screenshot. There are two ways to get it, and both change the package format, so it's a maintainer's call:

  1. An optional dark screenshot. package.json gains a second path, such as screenshotDark, and the index gains a matching URL. stablebar-packages CI checks it like screenshot, and its README can show both with <picture>. This is the smaller change, but authors make two images by hand, and they can drift from the widget.
  2. Previews drawn by StableBar. Store CI draws each package's widgets offscreen, as --render-scenes does, in Light and Dark. It uses sample values the package declares and publishes both images. Previews then come from the real layout engine and stay current, but this needs a format for sample values and CI work in both repositories.

Drawing the preview live in Settings doesn't work today. StableBar must not run a package's providers or commands before review. WidgetSampleContent draws a widget's default layout with generic sample values, not the package's own layout (Sources/StableBar/PackageListPreview.swift:62). Status ring would show as an icon and a number, not as its ring.

Possible today

No. PackagePreview shows screenshotData before anything else (Sources/StableBar/PackageDetailView.swift:414), and the manifest and the index each have one screenshot. WidgetPackageManifest rejects unknown keys (Sources/StableBar/WidgetPackage.swift:14), so a package using a new key needs a minimumVersion at or above the release that adds it. The index ignores keys it doesn't know. Checked on origin/main at da7455a and on stablebar-packages main.

Related

  • #144 / #152 added previews to the package list.
  • #818 covers the page's icon, which differs from the row's.

Triaged by Claude Code (Claude Opus 5.5).

主要言語
Swift
スター
184
フォーク
12
平均マージ
3時間 50分
マージ済み PR(30日)
387

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Seb-GRAF/StableBar のほかの issue

Seb-GRAF/StableBar の issue をすべて見る

似ている issue

Swift の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。