Keep settings tuned for one theme from applying under every other theme

オープン
#666 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
macos, swift
領域
design, desktop

調査の方向性

Start with Sources/StableBar/ThemeConfiguration.swift and Sources/StableBar/ConfigurationLoader.swift to understand profile conditions and when the selected theme is resolved; then read Sources/StableBar/WidgetPackage.swift and Sources/StableBar/Configuration.swift for theme and configuration validation. The proposal also spans profile editing, Theme and widget Style settings, and undoable configuration changes, so identify those entry points before estimating implementation. Done means theme conditions match the selected theme as described and theme scoped settings can be edited and migrated in Settings.

索引モデルが issue の本文から書いたものです。

説明

enhancement

Problem

A theme can't hold everything its look needs. A theme may contain only tokens, defaults, popupDefaults, roles, workspaceDefaults, bar, groups and profiles (validateThemeDocument in Sources/StableBar/WidgetPackage.swift), so the rest of the look goes in the main file:

  • widget paddings sized for the theme's pills
  • a clock drawn as an accent chip
  • a filled slider style
  • an Apple menu symbol
  • a package widget's layout in widgetOverrides
  • empty groups entries, needed only because a widget in a group the theme doesn't define fails the whole configuration ("Unknown group" in Sources/StableBar/Configuration.swift)

Those values apply under every theme. Switch from Fern to Nord and the clock is still an @token.accent chip, and the widgets keep paddings meant for pills. Theme lists the values below the gallery, and Reset them deletes them, so going back to Fern means doing the work again.

Profiles can't help: they match appearance, onBattery, displayCount, externalDisplay and app (ProfileConditions in Sources/StableBar/ThemeConfiguration.swift), not the theme.

Proposal

  1. A theme profile condition that matches the selected theme's ID, at any version, with "built-in" for Built-in:

    "profiles": [
      {
        "name": "Fern",
        "when": { "theme": "fern" },
        "configuration": {
          "widgetOverrides": {
            "date": { "group": "clock", "background": "@token.accent" },
            "battery": { "group": "status", "style": { "paddingHorizontal": 12 } }
          },
          "groups": { "clock": { "style": { "paddingLeading": 3 } } }
        }
      }
    ]
    

    composeFiles in Sources/StableBar/ConfigurationLoader.swift settles the theme before profiles apply, including a screen setup's own theme and the theme Try Themes shows, so the condition reads that theme and a profile can't change it in a loop. Group memberships can move into the profile too, so the main file no longer needs empty groups. Versions that don't know the condition never match it (Files from a newer StableBar), so the profile just stays off there.

  2. Settings → Profiles → + Condition offers Theme, listing the built-in and installed themes.

  3. At the top of Theme and in a widget's Style tab, a scope switch: Every theme or Only with Fern. With Only with Fern, changes save into a profile with that condition, created on first use, the way Edit the bar for this profile saves into a profile today.

  4. When the main file overrides the theme, Theme's notice offers to keep those values with a theme as well as Reset them: it moves them into that theme's profile in one undoable change.

The exact wording and placement of the switch and the notice are a matter of taste; renders of a few options can follow in a comment.

Possible today

Partly. Put the settings in a profile without when and turn it off with "enabled": false when switching theme, or pin it with "profile" or StableBar --profile. Pinning turns off automatic matching for every other profile, and nothing ties either way to the theme.

Related

  • #81 asked for profile conditions set by commands and was closed as not planned ("--profile covers most of it"). The theme is different: StableBar already knows it, and pinning a profile turns off automatic matching for the others.
  • #28 stopped colors that StableBar wrote from overriding a chosen theme, #30 lists what overrides the theme, and Save as Theme (#91, #143) moves the shared look into a theme but leaves widget styles in the main file.
  • #648 (open) adds group editing in Settings, which writes groups and widget group.
  • Themes that carry named looks (any role name, with roles and groups the theme lacks ignored) were considered instead. They would let a theme package ship reusable looks, but they change what a role is, and they can't hold a widget's own layout or symbol.

Triaged by Claude Code (Claude Opus 5.5).

主要言語
Swift
スター
184
フォーク
12
平均マージ
3時間 50分
マージ済み PR(30日)
387

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Seb-GRAF/StableBar のほかの issue

Seb-GRAF/StableBar の issue をすべて見る

似ている issue

Swift の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。