Keep settings tuned for one theme from applying under every other theme
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
Direzione di ricerca
Start with Sources/StableBar/ThemeConfiguration.swift and Sources/StableBar/ConfigurationLoader.swift to understand profile conditions and when the selected theme is resolved; then read Sources/StableBar/WidgetPackage.swift and Sources/StableBar/Configuration.swift for theme and configuration validation. The proposal also spans profile editing, Theme and widget Style settings, and undoable configuration changes, so identify those entry points before estimating implementation. Done means theme conditions match the selected theme as described and theme scoped settings can be edited and migrated in Settings.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
A theme can't hold everything its look needs. A theme may contain only tokens, defaults, popupDefaults, roles, workspaceDefaults, bar, groups and profiles (validateThemeDocument in Sources/StableBar/WidgetPackage.swift), so the rest of the look goes in the main file:
- widget paddings sized for the theme's pills
- a clock drawn as an accent chip
- a filled slider style
- an Apple menu symbol
- a package widget's layout in
widgetOverrides - empty
groupsentries, needed only because a widget in a group the theme doesn't define fails the whole configuration ("Unknown group" inSources/StableBar/Configuration.swift)
Those values apply under every theme. Switch from Fern to Nord and the clock is still an @token.accent chip, and the widgets keep paddings meant for pills. Theme lists the values below the gallery, and Reset them deletes them, so going back to Fern means doing the work again.
Profiles can't help: they match appearance, onBattery, displayCount, externalDisplay and app (ProfileConditions in Sources/StableBar/ThemeConfiguration.swift), not the theme.
Proposal
-
A
themeprofile condition that matches the selected theme's ID, at any version, with"built-in"for Built-in:"profiles": [ { "name": "Fern", "when": { "theme": "fern" }, "configuration": { "widgetOverrides": { "date": { "group": "clock", "background": "@token.accent" }, "battery": { "group": "status", "style": { "paddingHorizontal": 12 } } }, "groups": { "clock": { "style": { "paddingLeading": 3 } } } } } ]composeFilesinSources/StableBar/ConfigurationLoader.swiftsettles the theme before profiles apply, including a screen setup's own theme and the theme Try Themes shows, so the condition reads that theme and a profile can't change it in a loop. Group memberships can move into the profile too, so the main file no longer needs emptygroups. Versions that don't know the condition never match it (Files from a newer StableBar), so the profile just stays off there. -
Settings → Profiles → + Condition offers Theme, listing the built-in and installed themes.
-
At the top of Theme and in a widget's Style tab, a scope switch: Every theme or Only with Fern. With Only with Fern, changes save into a profile with that condition, created on first use, the way Edit the bar for this profile saves into a profile today.
-
When the main file overrides the theme, Theme's notice offers to keep those values with a theme as well as Reset them: it moves them into that theme's profile in one undoable change.
The exact wording and placement of the switch and the notice are a matter of taste; renders of a few options can follow in a comment.
Possible today
Partly. Put the settings in a profile without when and turn it off with "enabled": false when switching theme, or pin it with "profile" or StableBar --profile. Pinning turns off automatic matching for every other profile, and nothing ties either way to the theme.
Related
- #81 asked for profile conditions set by commands and was closed as not planned ("
--profilecovers most of it"). The theme is different: StableBar already knows it, and pinning a profile turns off automatic matching for the others. - #28 stopped colors that StableBar wrote from overriding a chosen theme, #30 lists what overrides the theme, and Save as Theme (#91, #143) moves the shared look into a theme but leaves widget styles in the main file.
- #648 (open) adds group editing in Settings, which writes
groupsand widgetgroup. - Themes that carry named looks (any role name, with roles and groups the theme lacks ignored) were considered instead. They would let a theme package ship reusable looks, but they change what a role is, and they can't hold a widget's own layout or symbol.
Triaged by Claude Code (Claude Opus 5.5).
- Lingua principale
- Swift
- Stelle
- 184
- Fork
- 12
- Merge medio
- 3h 50m
- PR unite (30g)
- 387
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Seb-GRAF/StableBar
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
I maintainer di solito rispondono entro 1 giorno
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changeForse già presa @Jonathanm10 l’ha presa oggi. Apertaneeds-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 30/100
I maintainer di solito rispondono entro 1 giorno
-
Allow the App Menu to display the frontmost app iconForse già presa @khatami10 l’ha presa oggi. Apertaenhancement needs-triage
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Seb-GRAF/StableBar
Issue simili
-
good first issue help wanted testing
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
-
area:cli documentation good first issue priority:low
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 94/100
isaaclins/freesnitch#430 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno