Keep settings tuned for one theme from applying under every other theme

Abierto
#666 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
macos, swift
Área
design, desktop

Línea de trabajo

Start with Sources/StableBar/ThemeConfiguration.swift and Sources/StableBar/ConfigurationLoader.swift to understand profile conditions and when the selected theme is resolved; then read Sources/StableBar/WidgetPackage.swift and Sources/StableBar/Configuration.swift for theme and configuration validation. The proposal also spans profile editing, Theme and widget Style settings, and undoable configuration changes, so identify those entry points before estimating implementation. Done means theme conditions match the selected theme as described and theme scoped settings can be edited and migrated in Settings.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Problem

A theme can't hold everything its look needs. A theme may contain only tokens, defaults, popupDefaults, roles, workspaceDefaults, bar, groups and profiles (validateThemeDocument in Sources/StableBar/WidgetPackage.swift), so the rest of the look goes in the main file:

  • widget paddings sized for the theme's pills
  • a clock drawn as an accent chip
  • a filled slider style
  • an Apple menu symbol
  • a package widget's layout in widgetOverrides
  • empty groups entries, needed only because a widget in a group the theme doesn't define fails the whole configuration ("Unknown group" in Sources/StableBar/Configuration.swift)

Those values apply under every theme. Switch from Fern to Nord and the clock is still an @token.accent chip, and the widgets keep paddings meant for pills. Theme lists the values below the gallery, and Reset them deletes them, so going back to Fern means doing the work again.

Profiles can't help: they match appearance, onBattery, displayCount, externalDisplay and app (ProfileConditions in Sources/StableBar/ThemeConfiguration.swift), not the theme.

Proposal

  1. A theme profile condition that matches the selected theme's ID, at any version, with "built-in" for Built-in:

    "profiles": [
      {
        "name": "Fern",
        "when": { "theme": "fern" },
        "configuration": {
          "widgetOverrides": {
            "date": { "group": "clock", "background": "@token.accent" },
            "battery": { "group": "status", "style": { "paddingHorizontal": 12 } }
          },
          "groups": { "clock": { "style": { "paddingLeading": 3 } } }
        }
      }
    ]
    

    composeFiles in Sources/StableBar/ConfigurationLoader.swift settles the theme before profiles apply, including a screen setup's own theme and the theme Try Themes shows, so the condition reads that theme and a profile can't change it in a loop. Group memberships can move into the profile too, so the main file no longer needs empty groups. Versions that don't know the condition never match it (Files from a newer StableBar), so the profile just stays off there.

  2. Settings → Profiles → + Condition offers Theme, listing the built-in and installed themes.

  3. At the top of Theme and in a widget's Style tab, a scope switch: Every theme or Only with Fern. With Only with Fern, changes save into a profile with that condition, created on first use, the way Edit the bar for this profile saves into a profile today.

  4. When the main file overrides the theme, Theme's notice offers to keep those values with a theme as well as Reset them: it moves them into that theme's profile in one undoable change.

The exact wording and placement of the switch and the notice are a matter of taste; renders of a few options can follow in a comment.

Possible today

Partly. Put the settings in a profile without when and turn it off with "enabled": false when switching theme, or pin it with "profile" or StableBar --profile. Pinning turns off automatic matching for every other profile, and nothing ties either way to the theme.

Related

  • #81 asked for profile conditions set by commands and was closed as not planned ("--profile covers most of it"). The theme is different: StableBar already knows it, and pinning a profile turns off automatic matching for the others.
  • #28 stopped colors that StableBar wrote from overriding a chosen theme, #30 lists what overrides the theme, and Save as Theme (#91, #143) moves the shared look into a theme but leaves widget styles in the main file.
  • #648 (open) adds group editing in Settings, which writes groups and widget group.
  • Themes that carry named looks (any role name, with roles and groups the theme lacks ignored) were considered instead. They would let a theme package ship reusable looks, but they change what a role is, and they can't hold a widget's own layout or symbol.

Triaged by Claude Code (Claude Opus 5.5).

Lenguaje dominante
Swift
Estrellas
184
Forks
12
Merge medio
3 h 50 min
PR fusionados (30 d)
387

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Seb-GRAF/StableBar

Todos los issues de Seb-GRAF/StableBar

Issues similares

Más issues de Swift

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.