Keep settings tuned for one theme from applying under every other theme
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start with Sources/StableBar/ThemeConfiguration.swift and Sources/StableBar/ConfigurationLoader.swift to understand profile conditions and when the selected theme is resolved; then read Sources/StableBar/WidgetPackage.swift and Sources/StableBar/Configuration.swift for theme and configuration validation. The proposal also spans profile editing, Theme and widget Style settings, and undoable configuration changes, so identify those entry points before estimating implementation. Done means theme conditions match the selected theme as described and theme scoped settings can be edited and migrated in Settings.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
A theme can't hold everything its look needs. A theme may contain only tokens, defaults, popupDefaults, roles, workspaceDefaults, bar, groups and profiles (validateThemeDocument in Sources/StableBar/WidgetPackage.swift), so the rest of the look goes in the main file:
- widget paddings sized for the theme's pills
- a clock drawn as an accent chip
- a filled slider style
- an Apple menu symbol
- a package widget's layout in
widgetOverrides - empty
groupsentries, needed only because a widget in a group the theme doesn't define fails the whole configuration ("Unknown group" inSources/StableBar/Configuration.swift)
Those values apply under every theme. Switch from Fern to Nord and the clock is still an @token.accent chip, and the widgets keep paddings meant for pills. Theme lists the values below the gallery, and Reset them deletes them, so going back to Fern means doing the work again.
Profiles can't help: they match appearance, onBattery, displayCount, externalDisplay and app (ProfileConditions in Sources/StableBar/ThemeConfiguration.swift), not the theme.
Proposal
-
A
themeprofile condition that matches the selected theme's ID, at any version, with"built-in"for Built-in:"profiles": [ { "name": "Fern", "when": { "theme": "fern" }, "configuration": { "widgetOverrides": { "date": { "group": "clock", "background": "@token.accent" }, "battery": { "group": "status", "style": { "paddingHorizontal": 12 } } }, "groups": { "clock": { "style": { "paddingLeading": 3 } } } } } ]composeFilesinSources/StableBar/ConfigurationLoader.swiftsettles the theme before profiles apply, including a screen setup's own theme and the theme Try Themes shows, so the condition reads that theme and a profile can't change it in a loop. Group memberships can move into the profile too, so the main file no longer needs emptygroups. Versions that don't know the condition never match it (Files from a newer StableBar), so the profile just stays off there. -
Settings → Profiles → + Condition offers Theme, listing the built-in and installed themes.
-
At the top of Theme and in a widget's Style tab, a scope switch: Every theme or Only with Fern. With Only with Fern, changes save into a profile with that condition, created on first use, the way Edit the bar for this profile saves into a profile today.
-
When the main file overrides the theme, Theme's notice offers to keep those values with a theme as well as Reset them: it moves them into that theme's profile in one undoable change.
The exact wording and placement of the switch and the notice are a matter of taste; renders of a few options can follow in a comment.
Possible today
Partly. Put the settings in a profile without when and turn it off with "enabled": false when switching theme, or pin it with "profile" or StableBar --profile. Pinning turns off automatic matching for every other profile, and nothing ties either way to the theme.
Related
- #81 asked for profile conditions set by commands and was closed as not planned ("
--profilecovers most of it"). The theme is different: StableBar already knows it, and pinning a profile turns off automatic matching for the others. - #28 stopped colors that StableBar wrote from overriding a chosen theme, #30 lists what overrides the theme, and Save as Theme (#91, #143) moves the shared look into a theme but leaves widget styles in the main file.
- #648 (open) adds group editing in Settings, which writes
groupsand widgetgroup. - Themes that carry named looks (any role name, with roles and groups the theme lacks ignored) were considered instead. They would let a theme package ship reusable looks, but they change what a role is, and they can't hold a widget's own layout or symbol.
Triaged by Claude Code (Claude Opus 5.5).
- Lenguaje dominante
- Swift
- Estrellas
- 184
- Forks
- 12
- Merge medio
- 3 h 50 min
- PR fusionados (30 d)
- 387
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Seb-GRAF/StableBar
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changePosiblemente ocupada @Jonathanm10 la tomó hoy. Abiertoneeds-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
Los mantenedores suelen responder en 1 día
-
Allow the App Menu to display the frontmost app iconPosiblemente ocupada @khatami10 la tomó hoy. Abiertoenhancement needs-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
Todos los issues de Seb-GRAF/StableBar
Issues similares
-
good first issue help wanted testing
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
-
area:cli documentation good first issue priority:low
Dificultad 1/5 Menos de una hora Aptitud para principiantes 94/100
isaaclins/freesnitch#430 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día