Attach Wave source provenance to Whale execution traps

Aperta
  • Qualcosa non va?
#1,036 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
compilers

Direzione di ricerca

Start with whale/src/codegen/mod.rs:23, then compare it with ir/src/source.rs and the upstream metadata/trap path referenced by the issue. Coordinate with @LunaStev before implementation because source-ID ownership and failure semantics are unresolved. Done means supported guard traps preserve the original file and span, generated/default-argument provenance keeps its coordinates, and tests cover serialization round-trips, missing metadata, and resource limits.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

discussion enhancement help wanted

Motivation

The adapter uses Wave spans for source diagnostics, but does not populate upstream source metadata for generated execution guards. Current official Whale exposes SourceMetadata; future direct interpreter failures need a mapping back to the original Wave site.

Starting point: whale/src/codegen/mod.rs:23.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Compared adapter source handling with official ir/src/source.rs; this is metadata integration, not native execution. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

After #996, define source-ID ownership and connect divide/shift/cast/uninitialized guard locations to the upstream metadata/trap path. Keep malformed IR distinct from source/runtime failures.

Related: #996, #895. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • Supported guard traps identify the original source file/span.
  • Generated/default-argument provenance is retained without changing source coordinates.
  • Serialization round-trip, missing metadata fallback and resource limits are covered.
Lingua principale
Rust
Stelle
56
Fork
21
Merge medio
23h 20m
PR unite (30g)
45

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di wavefnd/Wave

Tutte le issue di wavefnd/Wave

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.