Attach Wave source provenance to Whale execution traps

Abierto
  • ¿Algo no está bien?
#1,036 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
compilers

Línea de trabajo

Start with whale/src/codegen/mod.rs:23, then compare it with ir/src/source.rs and the upstream metadata/trap path referenced by the issue. Coordinate with @LunaStev before implementation because source-ID ownership and failure semantics are unresolved. Done means supported guard traps preserve the original file and span, generated/default-argument provenance keeps its coordinates, and tests cover serialization round-trips, missing metadata, and resource limits.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

discussion enhancement help wanted

Motivation

The adapter uses Wave spans for source diagnostics, but does not populate upstream source metadata for generated execution guards. Current official Whale exposes SourceMetadata; future direct interpreter failures need a mapping back to the original Wave site.

Starting point: whale/src/codegen/mod.rs:23.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Compared adapter source handling with official ir/src/source.rs; this is metadata integration, not native execution. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

After #996, define source-ID ownership and connect divide/shift/cast/uninitialized guard locations to the upstream metadata/trap path. Keep malformed IR distinct from source/runtime failures.

Related: #996, #895. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • Supported guard traps identify the original source file/span.
  • Generated/default-argument provenance is retained without changing source coordinates.
  • Serialization round-trip, missing metadata fallback and resource limits are covered.
Lenguaje dominante
Rust
Estrellas
56
Forks
21
Merge medio
23 h 20 min
PR fusionados (30 d)
45

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de wavefnd/Wave

Todos los issues de wavefnd/Wave

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.