Autowiring: resolve union and intersection parameter types in DiContainer
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
Direzione di ricerca
Start by reading resolveParameter() in src/Di/DiContainer.php and note where it only handles ReflectionNamedType; also read autowire() since it shares that path. Add the new named constructor and message template in src/Di/Enums/ExceptionMessages.php, then write failing cases in tests/Unit/Di/ for each scenario listed in Acceptance. Done means those tests pass, ambiguous unions are not guessed, unsatisfied intersections are rejected, and CHANGELOG.md records the behavior change.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
Quantum\Di\DiContainer::resolveParameter() reads a parameter type only when it is a ReflectionNamedType. For a union (A|B) or an intersection (Reader&Writer) type the type is ignored, so the parameter falls through to the passed arguments, then the default value, then null.
Result (checked on PHP 8.1):
public function __construct(A|B $dep)fails with aTypeErrorthat gives no hint about the container.public function __construct(A|B|null $dep)silently receivesnull, even whenAis registered in the container.Reader&Writeris never resolved, even when an implementing class is registered.
Proposal
Resolve a union or intersection parameter only when the choice is unambiguous. Never guess from the declaration order and never pass null silently.
- Union: drop
nulland builtin members. If exactly one remaining member can be resolved (it is registered in the container, or it is an instantiable class), use it. If several can, do not pick one. - Intersection: use a registered or instantiable member and check that the result satisfies every part of the type (
instanceoffor each). A result that does not satisfy all parts is not used. - Otherwise: keep the existing order (passed argument, default value). If neither exists, throw a
DiExceptionwith a clear message (new named constructor and message template insrc/Di/Enums/ExceptionMessages.php) that names the class, the parameter and the type, instead of aTypeErroror a silentnull. - The same rules apply to
autowire()of a closure, which sharesresolveParameter().
Why not the order of declaration
Other containers differ: one rejects union types (Marko, a clear exception), one tries members in declaration order (Tempest, which also does not check that an intersection is satisfied as a whole), one tries each branch and verifies it (Canvas). Declaration order makes A|B and B|A behave differently, so it is not used here.
Acceptance
- Tests in
tests/Unit/Di/for: union with one registered member, union with none, union with several resolvable members,A|B|nullwith and without a default, intersection with a registered implementation that satisfies all parts, intersection that does not, closure autowiring. CHANGELOG.mdentry. A parameter that failed before with aTypeErrornow resolves or throws aDiException; the exception type changes, so it is noted as a behavior change.
Milestone 3.2.0 (a different exception type on a path that used to throw TypeError).
- Lingua principale
- PHP
- Stelle
- 43
- Fork
- 22
- Merge medio
- 54m
- PR unite (30g)
- 57
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di quantum-php/framework
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
quantum-php/framework#692 ·
I maintainer di solito rispondono entro 1 giorno
-
routing testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
quantum-php/framework#547 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
quantum-php/framework#694 ·
I maintainer di solito rispondono entro 1 giorno
-
Raise PHPStan to level 9Apertarefactoring tech debt
Difficoltà 5/5 Più di una settimana Idoneità per principianti 20/100
quantum-php/framework#693 ·
I maintainer di solito rispondono entro 1 giorno
-
install:debugbar reads the package folder from the working directory and uses the default storage adapterForse già presa @armanist l’ha presa oggi. Apertabug console debugbar good first issue
quantum-php/framework#691 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di quantum-php/framework
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
dependencies enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
bug origin:interactive status:available
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
I maintainer di solito rispondono entro 1 giorno
-
sync-en
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno