install:debugbar reads the package folder from the working directory and uses the default storage adapter

Aperta
#691 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@armanist ci sta già lavorando.

Dal 21/11/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

bug console debugbar good first issue

Summary

php qt install:debugbar reads the php-debugbar package folder relative to the current working directory and works through the application's default storage adapter, so it fails in two setups where it should publish the assets. A few smaller issues of the same code and of the cache adapters, found while reviewing #687, are fixed alongside.

Problems

  1. Working directory: the vendor path vendor/php-debugbar/php-debugbar/resources is relative. Run from another folder (cd public && php ../qt install:debugbar), the command throws FileSystemException ("directory does not exist") although the package is installed. Paths should resolve from the application base directory, as the target folder already does through assets_dir().
  2. Storage adapter: the command copies local files through FileSystemFactory::get(), which returns the application's default adapter. With fs.default set to dropbox or gdrive, it checks the local vendor folder in the cloud and fails. It should use the local adapter (FileSystemType::LOCAL).
  3. Error message: a file that cannot be copied is reported as "The directory … is not writable", which hides the cause (for example a locked or unreadable file). The message should name the file.
  4. Typo: "The debug ber already installed" should read "The debug bar is already installed".
  5. Cache docblocks: the @method annotations of the Cache facade are untyped (get($key, $default = null)), while the adapters declare the PSR-16 v3 types, so static analysis accepts cache()->get(42), which throws a TypeError. The *Multiple() methods of the four adapters do not list @throws InvalidCacheKeyException.

Scope

  • src/Console/Commands/DebugBarCommand.php: vendor path from base_dir(), the local adapter, a message that names the file, the typo; tests for the first three.
  • src/Cache/Cache.php and the four cache adapters: docblocks only.

Out of scope

  • All-or-nothing behaviour of the *Multiple() methods: PSR-16 does not require it.
  • Memcached and an expired TTL: a separate bug that also affects 3.1.x.
Lingua principale
PHP
Stelle
43
Fork
22
Merge medio
54m
PR unite (30g)
57

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di quantum-php/framework

Tutte le issue di quantum-php/framework

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.