Autowiring: resolve union and intersection parameter types in DiContainer

Abierto
#651 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
php
Área
backend

Línea de trabajo

Start by reading resolveParameter() in src/Di/DiContainer.php and note where it only handles ReflectionNamedType; also read autowire() since it shares that path. Add the new named constructor and message template in src/Di/Enums/ExceptionMessages.php, then write failing cases in tests/Unit/Di/ for each scenario listed in Acceptance. Done means those tests pass, ambiguous unions are not guessed, unsatisfied intersections are rejected, and CHANGELOG.md records the behavior change.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

di enhancement

Problem

Quantum\Di\DiContainer::resolveParameter() reads a parameter type only when it is a ReflectionNamedType. For a union (A|B) or an intersection (Reader&Writer) type the type is ignored, so the parameter falls through to the passed arguments, then the default value, then null.

Result (checked on PHP 8.1):

  • public function __construct(A|B $dep) fails with a TypeError that gives no hint about the container.
  • public function __construct(A|B|null $dep) silently receives null, even when A is registered in the container.
  • Reader&Writer is never resolved, even when an implementing class is registered.

Proposal

Resolve a union or intersection parameter only when the choice is unambiguous. Never guess from the declaration order and never pass null silently.

  1. Union: drop null and builtin members. If exactly one remaining member can be resolved (it is registered in the container, or it is an instantiable class), use it. If several can, do not pick one.
  2. Intersection: use a registered or instantiable member and check that the result satisfies every part of the type (instanceof for each). A result that does not satisfy all parts is not used.
  3. Otherwise: keep the existing order (passed argument, default value). If neither exists, throw a DiException with a clear message (new named constructor and message template in src/Di/Enums/ExceptionMessages.php) that names the class, the parameter and the type, instead of a TypeError or a silent null.
  4. The same rules apply to autowire() of a closure, which shares resolveParameter().

Why not the order of declaration

Other containers differ: one rejects union types (Marko, a clear exception), one tries members in declaration order (Tempest, which also does not check that an intersection is satisfied as a whole), one tries each branch and verifies it (Canvas). Declaration order makes A|B and B|A behave differently, so it is not used here.

Acceptance

  • Tests in tests/Unit/Di/ for: union with one registered member, union with none, union with several resolvable members, A|B|null with and without a default, intersection with a registered implementation that satisfies all parts, intersection that does not, closure autowiring.
  • CHANGELOG.md entry. A parameter that failed before with a TypeError now resolves or throws a DiException; the exception type changes, so it is noted as a behavior change.

Milestone 3.2.0 (a different exception type on a path that used to throw TypeError).

Lenguaje dominante
PHP
Estrellas
43
Forks
22
Merge medio
54 min
PR fusionados (30 d)
57

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de quantum-php/framework

Todos los issues de quantum-php/framework

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.