Autowiring: resolve union and intersection parameter types in DiContainer
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 68/100
Rechercherichtung
Start by reading resolveParameter() in src/Di/DiContainer.php and note where it only handles ReflectionNamedType; also read autowire() since it shares that path. Add the new named constructor and message template in src/Di/Enums/ExceptionMessages.php, then write failing cases in tests/Unit/Di/ for each scenario listed in Acceptance. Done means those tests pass, ambiguous unions are not guessed, unsatisfied intersections are rejected, and CHANGELOG.md records the behavior change.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Problem
Quantum\Di\DiContainer::resolveParameter() reads a parameter type only when it is a ReflectionNamedType. For a union (A|B) or an intersection (Reader&Writer) type the type is ignored, so the parameter falls through to the passed arguments, then the default value, then null.
Result (checked on PHP 8.1):
public function __construct(A|B $dep)fails with aTypeErrorthat gives no hint about the container.public function __construct(A|B|null $dep)silently receivesnull, even whenAis registered in the container.Reader&Writeris never resolved, even when an implementing class is registered.
Proposal
Resolve a union or intersection parameter only when the choice is unambiguous. Never guess from the declaration order and never pass null silently.
- Union: drop
nulland builtin members. If exactly one remaining member can be resolved (it is registered in the container, or it is an instantiable class), use it. If several can, do not pick one. - Intersection: use a registered or instantiable member and check that the result satisfies every part of the type (
instanceoffor each). A result that does not satisfy all parts is not used. - Otherwise: keep the existing order (passed argument, default value). If neither exists, throw a
DiExceptionwith a clear message (new named constructor and message template insrc/Di/Enums/ExceptionMessages.php) that names the class, the parameter and the type, instead of aTypeErroror a silentnull. - The same rules apply to
autowire()of a closure, which sharesresolveParameter().
Why not the order of declaration
Other containers differ: one rejects union types (Marko, a clear exception), one tries members in declaration order (Tempest, which also does not check that an intersection is satisfied as a whole), one tries each branch and verifies it (Canvas). Declaration order makes A|B and B|A behave differently, so it is not used here.
Acceptance
- Tests in
tests/Unit/Di/for: union with one registered member, union with none, union with several resolvable members,A|B|nullwith and without a default, intersection with a registered implementation that satisfies all parts, intersection that does not, closure autowiring. CHANGELOG.mdentry. A parameter that failed before with aTypeErrornow resolves or throws aDiException; the exception type changes, so it is noted as a behavior change.
Milestone 3.2.0 (a different exception type on a path that used to throw TypeError).
- Vorherrschende Sprache
- PHP
- Sterne
- 43
- Forks
- 22
- Ø Merge
- 54 Min.
- Gemergte PRs (30 T.)
- 57
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus quantum-php/framework
-
bug good first issue
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
quantum-php/framework#692 ·
Maintainer antworten meist innerhalb von 1 Tag
-
routing testing
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
quantum-php/framework#547 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 72/100
quantum-php/framework#694 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Raise PHPStan to level 9Offenrefactoring tech debt
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 20/100
quantum-php/framework#693 ·
Maintainer antworten meist innerhalb von 1 Tag
-
install:debugbar reads the package folder from the working directory and uses the default storage adapterEvtl. vergeben @armanist hat das heute übernommen. Offenbug console debugbar good first issue
quantum-php/framework#691 · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in quantum-php/framework
Ähnliche Issues
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
dependencies enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 80/100
Maintainer antworten meist innerhalb von 1 Tag
-
bug origin:interactive status:available
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
Maintainer antworten meist innerhalb von 1 Tag
-
sync-en
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
Maintainer antworten meist innerhalb von 1 Tag