Autowiring: resolve union and intersection parameter types in DiContainer

Offen
#651 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
php
Bereich
backend

Rechercherichtung

Start by reading resolveParameter() in src/Di/DiContainer.php and note where it only handles ReflectionNamedType; also read autowire() since it shares that path. Add the new named constructor and message template in src/Di/Enums/ExceptionMessages.php, then write failing cases in tests/Unit/Di/ for each scenario listed in Acceptance. Done means those tests pass, ambiguous unions are not guessed, unsatisfied intersections are rejected, and CHANGELOG.md records the behavior change.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

di enhancement

Problem

Quantum\Di\DiContainer::resolveParameter() reads a parameter type only when it is a ReflectionNamedType. For a union (A|B) or an intersection (Reader&Writer) type the type is ignored, so the parameter falls through to the passed arguments, then the default value, then null.

Result (checked on PHP 8.1):

  • public function __construct(A|B $dep) fails with a TypeError that gives no hint about the container.
  • public function __construct(A|B|null $dep) silently receives null, even when A is registered in the container.
  • Reader&Writer is never resolved, even when an implementing class is registered.

Proposal

Resolve a union or intersection parameter only when the choice is unambiguous. Never guess from the declaration order and never pass null silently.

  1. Union: drop null and builtin members. If exactly one remaining member can be resolved (it is registered in the container, or it is an instantiable class), use it. If several can, do not pick one.
  2. Intersection: use a registered or instantiable member and check that the result satisfies every part of the type (instanceof for each). A result that does not satisfy all parts is not used.
  3. Otherwise: keep the existing order (passed argument, default value). If neither exists, throw a DiException with a clear message (new named constructor and message template in src/Di/Enums/ExceptionMessages.php) that names the class, the parameter and the type, instead of a TypeError or a silent null.
  4. The same rules apply to autowire() of a closure, which shares resolveParameter().

Why not the order of declaration

Other containers differ: one rejects union types (Marko, a clear exception), one tries members in declaration order (Tempest, which also does not check that an intersection is satisfied as a whole), one tries each branch and verifies it (Canvas). Declaration order makes A|B and B|A behave differently, so it is not used here.

Acceptance

  • Tests in tests/Unit/Di/ for: union with one registered member, union with none, union with several resolvable members, A|B|null with and without a default, intersection with a registered implementation that satisfies all parts, intersection that does not, closure autowiring.
  • CHANGELOG.md entry. A parameter that failed before with a TypeError now resolves or throws a DiException; the exception type changes, so it is noted as a behavior change.

Milestone 3.2.0 (a different exception type on a path that used to throw TypeError).

Vorherrschende Sprache
PHP
Sterne
43
Forks
22
Ø Merge
54 Min.
Gemergte PRs (30 T.)
57

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus quantum-php/framework

Alle Issues in quantum-php/framework

Ähnliche Issues

Weitere Issues zu PHP

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.