Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

content-length is not policed when a stream ends with a trailers section

Aperta
  • Qualcosa non va?
#1,328 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

@feiiiiii5 ci sta già lavorando.

Dal 25/9/2026.

  • #1329 di @feiiiiii5 — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
76/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
networking

Direzione di ricerca

Start with H2Stream.receive_headers and the existing insufficient-body cases in tests/test_invalid_content_lengths.py, then trace how receive_data calls _track_content_length. Add coverage for trailers ending the stream, including missing and conflicting trailer content-length values, while preserving validation of syntactically invalid trailer values. Done means the trailer cases raise InvalidBodyLengthError when the DATA length is wrong and do not replace the header expectation.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

A stream that ends with a trailers section never has its content-length policed, and a content-length in the trailers silently overrides the one declared in the header section.

Description

H2Stream.receive_headers is the handler for every received HEADERS block — initial headers, informational responses and trailers. It called self._initialize_content_length(headers) unconditionally. But _track_content_length, which is where the actual comparison happens, was only ever called from receive_data:

if expected is not None:
    if expected < actual:
        raise InvalidBodyLengthError(expected, actual)

    if end_stream and expected != actual:
        raise InvalidBodyLengthError(expected, actual)

Trailers never go through receive_data, so end_stream is never True here and the short-body check never runs. Two concrete consequences:

  • Trailers without content-length: _initialize_content_length sets _expected_content_length back to None, so if expected is not None: skips validation altogether.
  • Trailers with content-length: the trailers value replaces the header-section value, so a peer could declare content-length: 10 in the headers and content-length: 3 in the trailers and have a 13-byte body accepted.

The too-much-data direction still errors, because expected < actual trips while receiving DATA frames. Only the short-body direction is silently accepted.

RFC 9113 § 8.1.1

A request or response is also malformed if the value of a content-length header field does not equal the sum of the DATA frame payload lengths that form the content, unless the message is defined as having no content. For example, 204 or 304 responses contain no content, as does the response to a HEAD request.

Malformed requests or responses that are detected MUST be treated as a stream error of type PROTOCOL_ERROR.

The listed exemptions are 204, 304 and HEAD. A trailers section is not one of them. This is the same check the project adopted in #123 ("Police content lengths when provided"), proposed in #114.

Steps to reproduce

Unit level, no network, in-memory bytes:

scenario result on 4.4.1
content-length: 3, DATA 10, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, trailers END_STREAM accepted
content-length: 15, no DATA, trailers END_STREAM accepted
content-length: 15, DATA 13, trailers content-length: 13 accepted

Existing coverage only exercises the DATA-frame case: test_insufficient_data and test_insufficient_data_empty_frame in tests/test_invalid_content_lengths.py.

Environment

  • h2 4.4.1, master at bc239af1d1b85bc70482804f30a0e0e587d90a08
  • Python 3.14, macOS

Fix

In receive_headers, when the block is trailers: run the same content-length parse so a syntactically invalid value there is still a ProtocolError, then restore the previous expectation, and finally validate the body where the stream actually ends.

Lingua principale
Python
Stelle
1k
Fork
197
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di python-hyper/h2

Tutte le issue di python-hyper/h2

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.