Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

content-length is not policed when a stream ends with a trailers section

Ouverte
  • Quelque chose ne va pas ?
#1,328 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 4 jours

@feiiiiii5 y travaille déjà.

Depuis le 25/9/2026.

  • #1329 par @feiiiiii5 — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
76/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
python
Domaine
networking

Piste de recherche

Start with H2Stream.receive_headers and the existing insufficient-body cases in tests/test_invalid_content_lengths.py, then trace how receive_data calls _track_content_length. Add coverage for trailers ending the stream, including missing and conflicting trailer content-length values, while preserving validation of syntactically invalid trailer values. Done means the trailer cases raise InvalidBodyLengthError when the DATA length is wrong and do not replace the header expectation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

A stream that ends with a trailers section never has its content-length policed, and a content-length in the trailers silently overrides the one declared in the header section.

Description

H2Stream.receive_headers is the handler for every received HEADERS block — initial headers, informational responses and trailers. It called self._initialize_content_length(headers) unconditionally. But _track_content_length, which is where the actual comparison happens, was only ever called from receive_data:

if expected is not None:
    if expected < actual:
        raise InvalidBodyLengthError(expected, actual)

    if end_stream and expected != actual:
        raise InvalidBodyLengthError(expected, actual)

Trailers never go through receive_data, so end_stream is never True here and the short-body check never runs. Two concrete consequences:

  • Trailers without content-length: _initialize_content_length sets _expected_content_length back to None, so if expected is not None: skips validation altogether.
  • Trailers with content-length: the trailers value replaces the header-section value, so a peer could declare content-length: 10 in the headers and content-length: 3 in the trailers and have a 13-byte body accepted.

The too-much-data direction still errors, because expected < actual trips while receiving DATA frames. Only the short-body direction is silently accepted.

RFC 9113 § 8.1.1

A request or response is also malformed if the value of a content-length header field does not equal the sum of the DATA frame payload lengths that form the content, unless the message is defined as having no content. For example, 204 or 304 responses contain no content, as does the response to a HEAD request.

Malformed requests or responses that are detected MUST be treated as a stream error of type PROTOCOL_ERROR.

The listed exemptions are 204, 304 and HEAD. A trailers section is not one of them. This is the same check the project adopted in #123 ("Police content lengths when provided"), proposed in #114.

Steps to reproduce

Unit level, no network, in-memory bytes:

scenario result on 4.4.1
content-length: 3, DATA 10, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, END_STREAM on DATA InvalidBodyLengthError
content-length: 15, DATA 13, trailers END_STREAM accepted
content-length: 15, no DATA, trailers END_STREAM accepted
content-length: 15, DATA 13, trailers content-length: 13 accepted

Existing coverage only exercises the DATA-frame case: test_insufficient_data and test_insufficient_data_empty_frame in tests/test_invalid_content_lengths.py.

Environment

  • h2 4.4.1, master at bc239af1d1b85bc70482804f30a0e0e587d90a08
  • Python 3.14, macOS

Fix

In receive_headers, when the block is trailers: run the same content-length parse so a syntactically invalid value there is still a ProtocolError, then restore the previous expectation, and finally validate the body where the stream actually ends.

Langage dominant
Python
Étoiles
1k
Forks
197
Aucune PR mergée en 30 j

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de python-hyper/h2

Toutes les issues de python-hyper/h2

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.