client: Maximum call stack size exceeded bursts during teleport loading; the report carried no stack (journal dedup)

Aperta
#3,425 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
frontend, tooling

Direzione di ricerca

Start in bug-report/journal.ts at recordError to see why the error event is missing from timeline.json, then check the dedup and export filter in archive.ts and the message-only listError in bug-report.ts. Reproduce by opening the Att.Grant window at the Donwhang blacksmith and scrolling with the magic-option-down control while watching the console for the stack. Done when the recursion is fixed with a test and a repeating error's first stack reaches the report.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: client bug priority: high

Report: https://discord.com/channels/1550530470430396426/1570495242120200334 (BR-261112-1747-51F8)

The report's "Recent client errors" field lists Uncaught RangeError: Maximum call stack size exceeded once at 12:54:01 and then about once a second from 12:55:09 to the report. The player was at the Donwhang blacksmith with the Att.Grant (avatar magic option) window open, scrolling its option list; the replay shows the window and the world working.

Gap: the report's timeline.json holds no error event at all, though the journal records errors with their stack (bug-report/journal.ts recordError) and the archive allows the error kind and stack field (archive.ts). So nothing tells us which code recursed. The embed's error list comes from bug-report.ts listError, which keeps only the message.

Next steps:

  1. Find out why the journal's error event is missing from the timeline: dedup by signature, the journal window, or the export filter dropping the event.
  2. Reproduce: open the blacksmith's Att.Grant with a dress inserted and scroll the option list (the magic-option-down control) with the browser console open, and capture the stack.
  3. Fix the recursion, and make sure a report always carries the first stack of a repeating error.

Done when the recursion is found and fixed with a test, and a report of a repeating error carries its stack.

Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.