client: Maximum call stack size exceeded bursts during teleport loading; the report carried no stack (journal dedup)

未关闭
#3,425 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript
领域
frontend, tooling

调研方向

Start in bug-report/journal.ts at recordError to see why the error event is missing from timeline.json, then check the dedup and export filter in archive.ts and the message-only listError in bug-report.ts. Reproduce by opening the Att.Grant window at the Donwhang blacksmith and scrolling with the magic-option-down control while watching the console for the stack. Done when the recursion is fixed with a test and a repeating error's first stack reaches the report.

由索引模型根据 Issue 内容生成。

描述

area: client bug priority: high

Report: https://discord.com/channels/1550530470430396426/1570495242120200334 (BR-261112-1747-51F8)

The report's "Recent client errors" field lists Uncaught RangeError: Maximum call stack size exceeded once at 12:54:01 and then about once a second from 12:55:09 to the report. The player was at the Donwhang blacksmith with the Att.Grant (avatar magic option) window open, scrolling its option list; the replay shows the window and the world working.

Gap: the report's timeline.json holds no error event at all, though the journal records errors with their stack (bug-report/journal.ts recordError) and the archive allows the error kind and stack field (archive.ts). So nothing tells us which code recursed. The embed's error list comes from bug-report.ts listError, which keeps only the message.

Next steps:

  1. Find out why the journal's error event is missing from the timeline: dedup by signature, the journal window, or the export filter dropping the event.
  2. Reproduce: open the blacksmith's Att.Grant with a dress inserted and scroll the option list (the magic-option-down control) with the browser console open, and capture the stack.
  3. Fix the recursion, and make sure a report always carries the first stack of a repeating error.

Done when the recursion is found and fixed with a test, and a report of a repeating error carries its stack.

主要语言
Go
星标
97
派生
61
平均合并
4 小时 14 分钟
30 天内合并 PR
913

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

opensro-dev/opensro 的其他 Issue

查看 opensro-dev/opensro 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。